Elixir tests fails on v1.19.0-rc.0

[slashmili]

Elixir and Erlang/OTP versions

building and running test on 514615d fails with

erlang version 27.2.4

asdf install elixir ref:514615d0347cb9bb513faa44ae1e36406979e516
....
==> ex_unit (ex_unit)
........................................................................................................................................................................................................................................................................................................................................................................

  1) test I/O protocol with get until (ExUnit.CaptureIOTest)
     test/ex_unit/capture_io_test.exs:181
     Assertion with == failed
     code:  assert :io.scan_erl_form(~c">") == {:error, {1, :erl_scan, {:string, 34, ~c"a"}}, 1}
     left:  {:error, {1, :erl_scan, {:unterminated, :string, ~c"a"}}, 1}
     right: {:error, {1, :erl_scan, {:string, 34, ~c"a"}}, 1}
     stacktrace:
       test/ex_unit/capture_io_test.exs:219: anonymous fn/0 in ExUnit.CaptureIOTest."test I/O protocol with get until"/1
       (ex_unit 1.17.0-dev) lib/ex_unit/capture_io.ex:287: ExUnit.CaptureIO.do_capture_gl/2
       (ex_unit 1.17.0-dev) lib/ex_unit/capture_io.ex:245: ExUnit.CaptureIO.do_with_io/3
       (ex_unit 1.17.0-dev) lib/ex_unit/capture_io.ex:139: ExUnit.CaptureIO.capture_io/2
       test/ex_unit/capture_io_test.exs:218: (test)

..............................................................
Finished in 4.3 seconds (2.2s on load, 0.2s async, 1.8s sync)
48 doctests, 375 tests, 1 failure

Operating system

MacOS 15.5

Current behavior

one test is failing.

Expected behavior

all tests pass.

[slashmili]

I also cloned the repo, built and ran the test and I still get the same error:

erl
Erlang/OTP 27 [erts-15.0] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1]

Eshell V15.0 (press Ctrl+G to abort, type help(). for help)

elixir ((514615d0)|✔) $…> make test
....
Randomized with seed 8760
==> ex_unit (ex_unit)
...............................................................................................................................................................................................................................................................................................................................................................

  1) test I/O protocol with get until (ExUnit.CaptureIOTest)
     test/ex_unit/capture_io_test.exs:181
     Assertion with == failed
     code:  assert :io.scan_erl_form(~c">") == {:error, {1, :erl_scan, {:string, 34, ~c"a"}}, 1}
     left:  {:error, {1, :erl_scan, {:unterminated, :string, ~c"a"}}, 1}
     right: {:error, {1, :erl_scan, {:string, 34, ~c"a"}}, 1}
     stacktrace:
       test/ex_unit/capture_io_test.exs:219: anonymous fn/0 in ExUnit.CaptureIOTest."test I/O protocol with get until"/1
       (ex_unit 1.17.0-dev) lib/ex_unit/capture_io.ex:287: ExUnit.CaptureIO.do_capture_gl/2
       (ex_unit 1.17.0-dev) lib/ex_unit/capture_io.ex:245: ExUnit.CaptureIO.do_with_io/3
       (ex_unit 1.17.0-dev) lib/ex_unit/capture_io.ex:139: ExUnit.CaptureIO.capture_io/2
       test/ex_unit/capture_io_test.exs:218: (test)

.......................................................................
Finished in 7.5 seconds (4.2s on load, 0.3s async, 2.9s sync)
48 doctests, 375 tests, 1 failure

Randomized with seed 703923
make: *** [test_ex_unit] Error 2

[josevalim]

It seems to be a change on latest Erlang, we should match on both formats for now, something in like:

# TODO: Keep only the latter in Erlang/OTP 28+
assert :io.scan_erl_form(~c">") in [
  {:error, {1, :erl_scan, {:string, 34, ~c"a"}}, 1},
  {:error, {1, :erl_scan, {:unterminated, :string, ~c"a"}}, 1}
]

Would you like to send a PR? :)

[slashmili]

Thanks for the hint!

It's fixed in main

elixir/lib/ex_unit/test/ex_unit/capture_io_test.exs

Lines 258 to 264 in cf8689e

	# TODO: Remove me when we require Erlang/OTP 27+
	expected_error =
	if System.otp_release() >= "27" do
	{1, :erl_scan, {:unterminated, :string, ~c"a"}}
	else
	{1, :erl_scan, {:string, 34, ~c"a"}}
	end

I'd assume it will be ported to 1.19 before the final release

[josevalim]

IT is already there: https://github.com/elixir-lang/elixir/blob/v1.19/lib/ex_unit/test/ex_unit/capture_io_test.exs#L258-L264

looking at your test results, you were running tests on the v1.17 branch :)