The following condition is always false because we compare list and tuple:
|
if values.shape != shape: |
We need to refactor the code to avoid performing this code in SplinePPForm class. It violates the single responsibility principle and also the encapsulation.
SplinePPForm class should know nothing about:
- shape
- axis
- other things which are not related to evaluating data
The reshaping result array should be performed in the __call__ method of the caller class (CubicSmoothingSpline), but not in SplinePPForm class.
The following condition is always false because we compare list and tuple:
csaps/csaps/_sspumv.py
Line 110 in 6a301dc
We need to refactor the code to avoid performing this code in
SplinePPFormclass. It violates the single responsibility principle and also the encapsulation.SplinePPFormclass should know nothing about:The reshaping result array should be performed in the
__call__method of the caller class (CubicSmoothingSpline), but not inSplinePPFormclass.