This repository was archived by the owner on Feb 9, 2026. It is now read-only.
Repository navigation
Equipment Support - #5
Closed
jeremy-green wants to merge 6 commits into
Closed
jeremy-green wants to merge 6 commits into
jeremy-green wants to merge 6 commits into
Conversation
This commit adds support for Grocy's Equipment feature to the PyGrocy2 library: - Add Equipment data model (data_models/equipment.py) - Add Equipment API client methods in grocy_api_client.py - Add Equipment methods to Grocy class - Add unit tests for Equipment model - Update imports in test files
This commit removes the code and properties related to equipment maintenance since this functionality is not currently implemented in Grocy. The implementation now focuses solely on the equipment properties currently available in the Grocy API. Changes: - Remove maintenance fields from EquipmentDetailsResponse - Remove maintenance properties from Equipment class - Update tests to reflect the simplified implementation - Clean up code comments that referenced future functionality
Owner
|
Hi @jeremy-green I had to change base branch for your MR because I changed default branch and a few other dev stuff in this repo. I will review your PR now! :D |
iamkarlson
self-requested a review
January 22, 2026 21:34
Owner
|
Merged as part of #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support for Grocy's Equipment feature to the PyGrocy2 library:
Checklist