feat: Add GDCH support #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

poanc merged 27 commits into googleapis:main from poanc:gdch

Dec 6, 2022

Contributor

poanc commented Nov 9, 2022 •

edited by TimurSadykov

Loading

Add support for GDCH in Java. See the Java implementation design doc for more detail: go/gdch-java-auth-lib.

GDCH for auth lib design doc and Python implementation could be found in go/gdch-python-auth-lib.

Fixes #960


          feat: add GDCH support

83e64aa

poanc added the kokoro:force-run label

poanc requested a review from TimurSadykov

November 9, 2022 20:43

poanc requested a review from a team as a code owner

November 9, 2022 20:43

product-auto-label bot added the size: xl label

kokoro-team removed the kokoro:force-run label


          feat: add GDCH support

e58ca72

poanc closed this

poanc deleted the gdch branch

November 10, 2022 19:22

poanc restored the gdch branch

November 10, 2022 19:22

poanc reopened this

poanc added 5 commits

November 10, 2022 11:35


          Add additional test cases.

e27297a


          fix the format

c324427


          change the grant_type to token exchange type

11269df


          add more unit tests


          remove implementing JwtProvider from GdchCredentials class

1c4c14f

TimurSadykov suggested changes

View reviewed changes

TimurSadykov left a comment

Few comments, not finished yet

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

TimurSadykov requested a review from arithmetic1728

November 14, 2022 23:27

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved


          address the comments

ec8e36f

arithmetic1728 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved


          add custom httpTransport for ca cert

fd85a6a

poanc requested a review from a team as a code owner

November 17, 2022 05:29


          add more unit test

b63b9b5

poanc added 2 commits

November 29, 2022 09:20


          address the comments

c013f0d


          fix test cert path

c2b5ed1

poanc changed the title ~~feat: add GDCH support~~ feat: Add GDCH support

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/OAuth2Utils.java Show resolved Hide resolved

TimurSadykov reviewed

View reviewed changes

TimurSadykov left a comment

Couple small comments and a question

poanc added 4 commits

December 1, 2022 20:21


          remove privateKeyFromPkcs8 from ServiceAccountCredentials and refer…

1ae23b8

… to the helper method in OAuth2Utils


          Merge branch 'main' into gdch

1d4c27c


          add a javadoc for TransportFactoryForGdch

342b6eb


          Merge branch 'gdch' of github.com:poanc/google-auth-library-java into…

826663e

… gdch

TimurSadykov approved these changes

View reviewed changes

TimurSadykov left a comment

LGTM, Thanks!


          Merge branch 'main' into gdch

0dfc118

arithmetic1728 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

poanc added 2 commits

December 3, 2022 08:52


          change ca_cert_path to optional

f22d282


          Merge branch 'gdch' of github.com:poanc/google-auth-library-java into…

5932e45

… gdch

TimurSadykov reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved

poanc added 2 commits

December 4, 2022 09:55


          revert ca cert path to required

7e045e9


          Merge branch 'main' into gdch

dbbfc57

TimurSadykov requested review from blakeli0 and ddixit14 and removed request for ddixit14

December 5, 2022 10:18

blakeli0 reviewed

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved

poanc added 3 commits

December 6, 2022 01:03


          fix the format

2e6c280


          Merge branch 'gdch' of github.com:poanc/google-auth-library-java into…

e3b2a76

… gdch


          revert back to ca cert path optional

5b67c95

arithmetic1728 approved these changes

View reviewed changes

Contributor

arithmetic1728 left a comment

LGTM

poanc merged commit cfafb2d into googleapis:main

release-please bot mentioned this pull request

chore(main): release 1.14.0 #1096

Merged

yonghaoy mentioned this pull request

[no ticket][risk=low] Upgrade auth library and use legacy bundle service all-of-us/workbench#8487

Merged

12 tasks

release-please bot mentioned this pull request

chore(protobuf-4.x-rc): release 1.42.0-rc1 #1861

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels