Skip to content

fix: improve errors and warnings related to ADC #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimurSadykov merged 6 commits into from
May 12, 2023
Merged

fix: improve errors and warnings related to ADC #1172

TimurSadykov merged 6 commits into from
May 12, 2023

Conversation

@TimurSadykov
Copy link

@TimurSadykov TimurSadykov commented Feb 22, 2023

This change is part of the bigger work go/simplified-local-adc

Here we improve couple errors:

  1. When user does not have credential setup, we do not recommend setting up service account, rather we redirect to a new ADC setup page.
  2. We show warning about user credentials only if production environment is detected

@TimurSadykov TimurSadykov requested a review from a team as a code owner February 22, 2023 12:46
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 22, 2023
wangyutongg
wangyutongg approved these changes Feb 23, 2023
View reviewed changes
Copy link

@wangyutongg wangyutongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyutongg
Copy link

wangyutongg commented Feb 23, 2023

Nit: The second item in the description needs to be removed if we only fix the missing credentials error in this PR

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 23, 2023
@TimurSadykov TimurSadykov changed the title fix: improve missing credentials error fix: improve errors and warnings related to ADC Feb 23, 2023
@TimurSadykov
Copy link
Author

TimurSadykov commented Feb 23, 2023

Nit: The second item in the description needs to be removed if we only fix the missing credentials error in this PR

Updated the PR description, this PR covers both items

This was referenced Feb 23, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@TimurSadykov TimurSadykov requested a review from a team as a code owner May 10, 2023 07:28
@TimurSadykov
Copy link
Author

TimurSadykov commented May 10, 2023

Nit: The second item in the description needs to be removed if we only fix the missing credentials error in this PR

PTAL latest version - left the second part as we decided to keep it

wangyutongg
wangyutongg reviewed May 11, 2023
View reviewed changes
@TimurSadykov TimurSadykov merged commit 6d2251c into main May 12, 2023
@TimurSadykov TimurSadykov deleted the stim-simple branch May 12, 2023 23:13
@release-please release-please bot mentioned this pull request May 12, 2023
Merged
@release-please release-please bot mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wangyutongg wangyutongg wangyutongg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimurSadykov @wangyutongg