Repository navigation
feat(sql): configure sqladmin namespace and regenerate - #18268
Merged
Merged
Conversation
Configure python-gapic-name=sqladmin for google/cloud/sql/v1 and v1beta4 in librarian.yaml to avoid package path collisions with cloud-sql-python-connector (google.cloud.sql). Regenerate google-cloud-sql package and update release-please-individual-config.json extra-files paths accordingly. Fixes http://b/537731748 http://b/537730936
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Google Cloud SQL library by renaming package imports, module paths, and documentation references from google.cloud.sql to google.cloud.sqladmin (including v1 and v1beta4 versions). Feedback on the changes highlights critical issues in the documentation regeneration, specifically a version mismatch where v1 services are incorrectly documented under v1beta4 directories, and duplicated toctree entries in the main index file that could lead to broken links.
parthea
approved these changes
Sep 2, 2026
parthea
pushed a commit
that referenced
this pull request
Sep 2, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.1](google-cloud-sql-v0.1.0...google-cloud-sql-v0.1.1) (2026-09-02) ### Features * **sql:** configure sqladmin namespace and regenerate ([#18268](#18268)) ([21cc934](21cc934)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure
python-gapic-name=sqladminforgoogle/cloud/sql/v1andv1beta4inlibrarian.yamlto avoid package path collisions withcloud-sql-python-connector(google.cloud.sql).google-cloud-sqlpackage under thegoogle.cloud.sqladminnamespace.release-please-individual-config.jsonextra-filespaths forgoogle-cloud-sql.Internal tracking bug http://b/537731748 http://b/537730936