Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Commit a9e8e97

Browse files
author
Praful Makani
authored
refactor(samples): updates params and comments (#543)
1 parent 69a2965 commit a9e8e97

File tree

6 files changed

+7
-10
lines changed

6 files changed

+7
-10
lines changed

samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateAdManagerTransfer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ public static void main(String[] args) throws IOException {
3636
final String projectId = "MY_PROJECT_ID";
3737
String datasetId = "MY_DATASET_ID";
3838
String bucket = "gs://cloud-sample-data";
39-
String networkCode = "MY_NETWORK_CODE";
39+
// the network_code can only be digits with length 1 to 15
40+
String networkCode = "12345678";
4041
Map<String, Value> params = new HashMap<>();
4142
params.put("bucket", Value.newBuilder().setStringValue(bucket).build());
4243
params.put("network_code", Value.newBuilder().setStringValue(networkCode).build());
@@ -46,7 +47,6 @@ public static void main(String[] args) throws IOException {
4647
.setDisplayName("Your Ad Manager Config Name")
4748
.setDataSourceId("dfp_dt")
4849
.setParams(Struct.newBuilder().putAllFields(params).build())
49-
.setSchedule("every 24 hours")
5050
.build();
5151
createAdManagerTransfer(projectId, transferConfig);
5252
}

samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateAdsTransfer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ public static void main(String[] args) throws IOException {
3535
// TODO(developer): Replace these variables before running the sample.
3636
final String projectId = "MY_PROJECT_ID";
3737
String datasetId = "MY_DATASET_ID";
38-
String customerId = "MY_CUSTOMER_ID";
39-
String refreshWindow = "MY_REFRESH_WINDOW";
38+
// the customer_id only allows digits and hyphen ('-').
39+
String customerId = "012-345-6789";
40+
String refreshWindow = "100";
4041
Map<String, Value> params = new HashMap<>();
4142
params.put("customer_id", Value.newBuilder().setStringValue(customerId).build());
4243
params.put("refreshWindow", Value.newBuilder().setStringValue(refreshWindow).build());
@@ -46,7 +47,6 @@ public static void main(String[] args) throws IOException {
4647
.setDisplayName("Your Ads Transfer Config Name")
4748
.setDataSourceId("adwords")
4849
.setParams(Struct.newBuilder().putAllFields(params).build())
49-
.setSchedule("every 24 hours")
5050
.build();
5151
createAdsTransfer(projectId, transferConfig);
5252
}

samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateCampaignmanagerTransfer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ public static void main(String[] args) throws IOException {
3636
final String projectId = "MY_PROJECT_ID";
3737
String datasetId = "MY_DATASET_ID";
3838
String bucket = "gs://cloud-sample-data";
39-
String networkId = "MY_DOUBLE_CLICK_ID";
39+
// the network_id only allows digits
40+
String networkId = "7878";
4041
String fileNamePrefix = "test_";
4142
Map<String, Value> params = new HashMap<>();
4243
params.put("bucket", Value.newBuilder().setStringValue(bucket).build());
@@ -48,7 +49,6 @@ public static void main(String[] args) throws IOException {
4849
.setDisplayName("Your Campaignmanager Config Name")
4950
.setDataSourceId("dcm_dt")
5051
.setParams(Struct.newBuilder().putAllFields(params).build())
51-
.setSchedule("every 24 hours")
5252
.build();
5353
createCampaignmanagerTransfer(projectId, transferConfig);
5454
}

samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreatePlayTransfer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ public static void main(String[] args) throws IOException {
4646
.setDisplayName("Your Play Config Name")
4747
.setDataSourceId("play")
4848
.setParams(Struct.newBuilder().putAllFields(params).build())
49-
.setSchedule("every 24 hours")
5049
.build();
5150
createPlayTransfer(projectId, transferConfig);
5251
}

samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateYoutubeChannelTransfer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ public static void main(String[] args) throws IOException {
4444
.setDisplayName("Your Youtube Channel Config Name")
4545
.setDataSourceId("youtube_channel")
4646
.setParams(Struct.newBuilder().putAllFields(params).build())
47-
.setSchedule("every 24 hours")
4847
.build();
4948
createYoutubeChannelTransfer(projectId, transferConfig);
5049
}

samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateYoutubeContentOwnerTransfer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ public static void main(String[] args) throws IOException {
4646
.setDisplayName("Your Youtube Owner Channel Config Name")
4747
.setDataSourceId("youtube_content_owner")
4848
.setParams(Struct.newBuilder().putAllFields(params).build())
49-
.setSchedule("every 24 hours")
5049
.build();
5150
createYoutubeContentOwnerTransfer(projectId, transferConfig);
5251
}

0 commit comments

Comments
 (0)