Skip to content

feat: add crc32c_checksum argument to download_chunks_concurrently #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 9 commits into from
Oct 11, 2023
Merged

feat: add crc32c_checksum argument to download_chunks_concurrently #1138

gcf-merge-on-green merged 9 commits into from
Oct 11, 2023

Conversation

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Oct 6, 2023

No description provided.

@andrewsg andrewsg requested review from a team as code owners October 6, 2023 22:34
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Oct 6, 2023
@andrewsg andrewsg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large. labels Oct 6, 2023
@andrewsg andrewsg force-pushed the tm-download-crc32c branch from 970f84d to 273a249 Compare October 6, 2023 22:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Oct 6, 2023
@andrewsg andrewsg added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2023
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2023
frankyn
frankyn reviewed Oct 10, 2023
View reviewed changes
cojenco
cojenco reviewed Oct 11, 2023
View reviewed changes
@andrewsg andrewsg requested a review from a team as a code owner October 11, 2023 18:00
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 11, 2023
cojenco
cojenco approved these changes Oct 11, 2023
View reviewed changes
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2023
@andrewsg andrewsg removed the request for review from msampathkumar October 11, 2023 20:30
@gcf-merge-on-green gcf-merge-on-green bot merged commit fc92ad1 into main Oct 11, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the tm-download-crc32c branch October 11, 2023 20:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2023
@release-please release-please bot mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cojenco cojenco cojenco approved these changes

+1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewsg @frankyn @cojenco @yoshi-kokoro