feat: support custom universe domains/TPC #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojenco
reviewed
Jan 26, 2024
Contributor
cojenco
left a comment
There was a problem hiding this comment.
Looks great, thanks Andrew! Just a few minor questions
BrennaEpp
approved these changes
Feb 2, 2024
BrennaEpp
left a comment
There was a problem hiding this comment.
LGTM - thank you Andrew!
Please pull in googleapis/conformance-tests#89 and make required changes to your testing code to test the new cases (this can be in a separate PR).
39627fc to
a7df9a1
Compare
cojenco
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.