tests(smoke): re-enable dialog prompt #8894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
If this works out, should close #2423. |
Collaborator
Author
|
dbw passed fine but some totally unrelated smokes failed ... |
brendankenny
approved these changes
May 17, 2019
Contributor
brendankenny
left a comment
There was a problem hiding this comment.
LGTM, assigning to @paulirish since this was originally his thing
|
|
||
| <!--The javascriptDialogOpening test is disabled as we hit a platform bug frequently on travis--> | ||
| <!--<script>window.confirm('Is DBW Mega Tester the best site?')</script>--> | ||
| <script>window.confirm('Is DBW Mega Tester the best site?')</script> |
Contributor
There was a problem hiding this comment.
can you add a comment as to the purpose of this line
Contributor
|
also does that mean #2423 is fixed? |
paulirish
approved these changes
May 25, 2019
Member
paulirish
left a comment
There was a problem hiding this comment.
seems like it works now.
lighthouse https://output.jsbin.com/senapoqiva/1/quiet
is happy.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled here: #2437
Let's see what happens in Travis these days.
fixes #2423