Watchman should not be downloaded in CI or production images

[mlodic]

this should be downloaded only for local development

[geckiss]

Hello, not sure if this is correct issue but the default value of $WATCHMAN envar in Dockerfile is set incorrectly. It is set to false, however, watchman install script requires False, with capital F, to not install Watchman.

If you try to rebuild the image from repository, you can see Saving to: ‘watchman-v2024.02.12.00-linux.zip’ in output logs. However, if you set $WATCHMAN="False", you will see Skipping WATCHMAN installation because we are not in test mode.

[mlodic]

hey @geckiss thank you very much for your help. I think we are pretty bad with typos and so on 🤣 so please could you open a very little PR request to show the exact change that you have done? In this way we can understand it better and you can also get credit for your contribution :)

[github-actions]

This issue has been marked as stale because it has had no activity for 10 days. If you are still working on this, please provide some updates.

[ManaswibRane]

Hi @mlodic ,
I dont think there is any typo and the if else functionality is working
The downloading of Watchman depends on the $WATCHMAN variable from the Dockerfile.
We just need to set it accordingly during the build.
The max we can do is add an env variable but it again does the same thing, just that it will be an env variable unlike watchman being a docker build argument
Also do we want to change this
wget http://archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.0g-2ubuntu4_amd64.deb

Thanks !

[mlodic]

all the references/links are old, could you update them? Also, can you show that this actually works only for local development? (showing CLI executions with different dumps) If yes, I'll assign you

[ManaswibRane]

Hi @mlodic ,
Sorry for the delay :)
Here's my work
The required change was adding an env variable and setting it while building (--build-arg WATCHMAN=true (or false))

When $WATCHMAN set false

#20 6.305 + echo 'WATCHMAN value is '
#20 6.306 WATCHMAN value is 
#20 6.306 false
#20 6.306 + echo false
#20 6.306 + '[' false = false ']'
#20 6.307 + echo 'Skipping WATCHMAN installation because we are not in test mode'
#20 6.307 + exit 0
#20 6.307 Skipping WATCHMAN installation because we are not in test mode
#20 6.348 �[1m�[36m[*]�[0m�[0m Download the latest rules from https://github.com/quark-engine/quark-rules
#20 7.685 �[1m�[92m[+]�[0m�[0m DONE: Complete downloading the latest quark-rules

When $WATCHMAN set true

#14 8.795 + echo 'WATCHMAN value is '
#14 8.797 + echo true
#14 8.797 + '[' true = false ']'
#14 8.797 WATCHMAN value is 
#14 8.797 true
#14 8.799 + echo 'Not skipping since test mode'
#14 8.799 + pip3 install --compile -r requirements/django-server-requirements.txt
#14 8.799 Not skipping since test mode
#14 9.498 Collecting pywatchman==2.0.0 (from -r requirements/django-server-requirements.txt (line 2))
#14 10.20   Downloading pywatchman-2.0.0.tar.gz (40 kB)
#14 10.44   Installing build dependencies: started
#14 12.69   Installing build dependencies: finished with status 'done'
#14 12.70   Getting requirements to build wheel: started
#14 13.07   Getting requirements to build wheel: finished with status 'done'
#14 13.07   Preparing metadata (pyproject.toml): started
#14 13.23   Preparing metadata (pyproject.toml): finished with status 'done'
#14 13.23 Building wheels for collected packages: pywatchman
#14 13.24   Building wheel for pywatchman (pyproject.toml): started
#14 13.87   Building wheel for pywatchman (pyproject.toml): finished with status 'done'
#14 13.87   Created wheel for pywatchman: filename=pywatchman-2.0.0-cp311-cp311-linux_x86_64.whl size=78093 sha256=8947a830a61efc916afc8116eafaeca86dc40ab61c89bb50d8c598bff639dc45
#14 13.87   Stored in directory: /root/.cache/pip/wheels/6f/5a/c0/4b0c781fcffcafdf2fc0a565fe9ea4f34e43c133730da3dec2
#14 13.88 Successfully built pywatchman

Also since we are discussing versions got some logs

#14 49.16 npm warn deprecated workbox-cacheable-response@6.6.0: workbox-background-sync@6.6.0
#14 49.59 npm warn deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
#14 51.12 npm warn deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
#14 51.42 npm warn deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
#14 51.62 npm warn deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
#14 51.80 npm warn deprecated svgo@1.3.2: This SVGO version is no longer supported. Upgrade to v2.x.x.
#14 57.60 npm warn deprecated lodash.get@4.4.2: This package is deprecated. Use the optional chaining (?.) operator instead.
#14 57.63 npm warn deprecated lodash.isequal@4.5.0: This package is deprecated. Use require('node:util').isDeepStrictEqual instead.
#14 58.84 npm warn deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
#14 66.19 npm warn deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
#14 67.80 npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
#14 74.92 npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
#14 75.34 npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
#14 435.8 (node:60) [DEP0176] DeprecationWarning: fs.F_OK is deprecated, use fs.constants.F_OK instead
39.13 npm warn deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
39.64 npm warn deprecated lodash.get@4.4.2: This package is deprecated. Use the optional chaining (?.) operator instead.
39.77 npm warn deprecated lodash.isequal@4.5.0: This package is deprecated. Use require('node:util').isDeepStrictEqual instead.
44.04 npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
45.51 npm warn deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
55.97 npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
56.62 npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead

For changing versions into the watchman_install.sh file

Suggested change
wget https://github.com/facebook/watchman/archive/refs/tags/v2024.05.13.00.zip
to
wget https://github.com/facebook/watchman/archive/refs/tags/v2026.02.02.00.zip

and
wget http://archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.0g-2ubuntu4_amd64.deb
to
http://archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl3t64_3.5.4-1ubuntu1_amd64.deb
if we dont wanna change the structure else
apt-get update
apt-get install -y openssl libssl3

[mlodic]

plz go ahead

[mlodic]

could you also check whether the libssl is still required or not?

see this old commit: bf1cb60

It would be great to remove if not necessary to help future maintenance