fix(label): do not grow when in end slot - #29036
Merged
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
February 13, 2024 16:22
liamdebeasi
requested review from
averyrousseau
and removed request for
a team
February 13, 2024 16:22
brandyscarney
requested changes
Feb 13, 2024
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Can we add a test for this?
liamdebeasi
commented
Feb 13, 2024
Contributor
Author
There was a problem hiding this comment.
The Start slot looks larger than it should here, but I checked and this has been the behavior for a while. Not sure if this is a bug, but I decided that changing this is out of scope.
brandyscarney
approved these changes
Feb 14, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29033
What is the current behavior?
In #28773 I resolved several incorrect behaviors with Items related to text wrapping. However, it looks like I missed the removal of https://github.com/ionic-team/ionic-framework/pull/28146/files#diff-4a1156704dbf45b0dad273b6909b190ca45e4380aa7378ba88d0dd7d48d7d473R37 which caused the issue to persist when adding a label to the end slot.
What is the new behavior?
ion-labelto grow larger than it needed to bemainDoes this introduce a breaking change?
Other information
Dev build:
7.7.2-dev.11707840956.16e27b4c