perf(styles): compress distributed global stylesheets - #29275
Merged
Conversation
liamdebeasi
approved these changes
Apr 4, 2024
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this! We might want to make this a perf since this will reduce the bundle size for applications.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Ionic Framework developers make extensive use of multi-line comments in the Sass files. However these comments are not stripped from the generated output.
This leads to a significant increase to the file size of CSS and can have an impact on runtime performance.
For example: https://cdn.jsdelivr.net/npm/@ionic/core/css/core.css has 183 lines of comment blocks before a single line of CSS.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev-build:
7.8.4-dev.11712251308.1da8aede