Skip to content

Commit 109d8cb

Browse files
Alexander Duycktorvalds
authored andcommitted
checkpatch: only flag FSF address, not gnu.org URL
This change restricts the check for the for the FSF address in the GPL copyright statement so that it only flags the address, not the references to the gnu.org/licenses URL which appears to be used in numerous drivers. The idea is to still allow some reference to an external copy of the GPL in the event that files are copied out of the kernel tree without the COPYING file. So for example this statement will still return an error: You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. However, this statement will not return an error after this patch: You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Cc: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 31070b5 commit 109d8cb

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

scripts/checkpatch.pl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1970,14 +1970,12 @@ sub process {
19701970
}
19711971

19721972
# Check for FSF mailing addresses.
1973-
if ($rawline =~ /\bYou should have received a copy/i ||
1974-
$rawline =~ /\bwrite to the Free/i ||
1973+
if ($rawline =~ /\bwrite to the Free/i ||
19751974
$rawline =~ /\b59\s+Temple\s+Pl/i ||
19761975
$rawline =~ /\b51\s+Franklin\s+St/i) {
19771976
my $herevet = "$here\n" . cat_vet($rawline) . "\n";
19781977
my $msg_type = \&ERROR;
19791978
$msg_type = \&CHK if ($file);
1980-
$msg_type = \&CHK if ($rawline =~ /\bYou should have received a copy/i);
19811979
&{$msg_type}("FSF_MAILING_ADDRESS",
19821980
"Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
19831981
}

0 commit comments

Comments
 (0)