Enhance bindings for Crypt32 and fix bindings for array attributes#1252
Merged
matthiasblaesing merged 1 commit intoSep 8, 2020
Merged
Conversation
Member
Author
|
This changeset changes method signatures, but you'd need to be blind to use the methods in the way they were originally bound. They are obviously broken and thus from my POV don't form an api break. |
matthiasblaesing
force-pushed
the
fix-crypto32
branch
2 times, most recently
from
August 31, 2020 18:40
e9a76b9 to
6120932
Compare
dbwiddis
reviewed
Sep 2, 2020
dbwiddis
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. A few typos and questions more for my education than concern that they are wrong.
The implementations of the rgAttribute, rgCTLEntry and rgExtension attributes are not in line with the observed behaviour of the API. At least in part they are documented to be pointers to arrays of pointers to structures. This is not correct, as segfaults were observed and testing shows, that they are in fact pointers to arrays of structures. In addition it was observed, that the bindings of CTL_INFO#getRgCTLEntry and CTL_INFO#getRgExtension method names were inverted. The bindings for CERT_EXTENSIONS#getRgExtension and CTL_INFO#getRgExtension are untested as but assumed to be implemented identically to the tested bindings. The functions - CertEnumCertificatesInStore - CertEnumCTLsInStore - CertEnumCRLsInStore - CryptQueryObject from `c.s.j.p.win32.Crypt32` were bound to be able to excercise the accessors.
matthiasblaesing
force-pushed
the
fix-crypto32
branch
from
September 2, 2020 17:43
6120932 to
07fd6fd
Compare
Member
Author
|
I updated the PR - @dbwiddis ok to merge from your perspective? |
Contributor
|
Looks good from my point of view. I have not yet had time to actually test it, but I have looked closely at the code! |
Member
Author
|
@dbwiddis thank you for your review. I'll merge this in now, if you recognize a problem later (preferably before the next release) just speak up and I'll revisit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementations of the rgAttribute, rgCTLEntry and rgExtension
attributes are not in line with the observed behaviour of the API. At
least in part they are documented to be pointers to arrays of pointers
to structures. This is not correct, as segfaults were observed and
testing shows, that they are in fact pointers to arrays of structures.
In addition it was observed, that the bindings of CTL_INFO#getRgCTLEntry
and CTL_INFO#getRgExtension method names were inverted.
The bindings for CERT_EXTENSIONS#getRgExtension and
CTL_INFO#getRgExtension are untested as but assumed to be implemented
identically to the tested bindings.
The functions
from
c.s.j.p.win32.Crypt32were bound to be able to excercise theaccessors.