Fix native conversion for empty CFStringRef.#1275
Merged
Merged
Conversation
dbwiddis
approved these changes
Nov 24, 2020
dbwiddis
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the fix and the updated test case. One typo in the changelog, and can you squash the commits please?
dblock
reviewed
Nov 25, 2020
dbwiddis
reviewed
Nov 25, 2020
Contributor
|
Looks great to me. I'll merge after CI tests pass. |
Contributor
Author
|
Tks @dbwiddis , looking forward to contribute with some macOs binds when I consider it more stable. |
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in con.sun.jna.Memory(long) constructor: java.lang.IllegalArgumentException: Allocation size must be greater than zero
tresf
pushed a commit
to tresf/jna
that referenced
this pull request
Dec 1, 2020
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in con.sun.jna.Memory(long) constructor: java.lang.IllegalArgumentException: Allocation size must be greater than zero
dbwiddis
pushed a commit
to dbwiddis/jna
that referenced
this pull request
Jan 29, 2021
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in con.sun.jna.Memory(long) constructor: java.lang.IllegalArgumentException: Allocation size must be greater than zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in com.sun.jna.Memory(long) constructor:
java.lang.IllegalArgumentException: Allocation size must be greater than zero
Issue: #1274