Skip to content

Added CM_Get_DevNode_Registry_Property to Cfgmgr32 and Cfgmgr32Util#1340

Merged
dbwiddis merged 1 commit into
java-native-access:masterfrom
dbwiddis:cfgmgr
Apr 21, 2021
Merged

Added CM_Get_DevNode_Registry_Property to Cfgmgr32 and Cfgmgr32Util#1340
dbwiddis merged 1 commit into
java-native-access:masterfrom
dbwiddis:cfgmgr

Conversation

@dbwiddis

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread contrib/platform/src/com/sun/jna/platform/win32/Cfgmgr32Util.java Outdated
@dbwiddis
dbwiddis force-pushed the cfgmgr branch 5 times, most recently from 86b5e2f to 5ac24f4 Compare April 18, 2021 20:38
Comment thread contrib/platform/src/com/sun/jna/platform/win32/Cfgmgr32Util.java Outdated
@dbwiddis

dbwiddis commented Apr 20, 2021

Copy link
Copy Markdown
Contributor Author

Checkstyle doesn't like Java Coding Convention standard for switch/case. I can't easily switch it in my IDE, either. Maybe i'll just make it an if/then...

@matthiasblaesing matthiasblaesing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly sane to me, I left two inline comments.

Comment thread contrib/platform/src/com/sun/jna/platform/win32/Advapi32Util.java Outdated
Comment thread contrib/platform/src/com/sun/jna/platform/win32/Cfgmgr32Util.java Outdated

@matthiasblaesing matthiasblaesing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@dbwiddis

Copy link
Copy Markdown
Contributor Author

Thanks as always for your patience and educational code review.

@dbwiddis
dbwiddis merged commit 7a33efb into java-native-access:master Apr 21, 2021
@dbwiddis
dbwiddis deleted the cfgmgr branch January 9, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants