Repository navigation
Add a memory-mapped RandomAccessReader using MemorySegment api - #296
Conversation
9ffd328 to
edf50bb
Compare
|
Outstanding! Can you wire this into ReaderSupplierFactory (replacing MMapReaderSupplier)? Not sure if reflection is needed given the module configuration. |
|
Thank you @mdogan! I feel your pain here regarding module placement. We could adopt Maven Toolchains so that we could call out to a Java 20 compiler in |
I'd prefer this to be in `jvector-twenty` module. But `--enable-preview` flag is only allowed for the Java release version used to compile the code. When building with Java 22, `--enable-preview` is not allowed on `twenty` module because it builds for Java 20.
edf50bb to
ee2fb37
Compare
Done. |
Actually I don't care about Java 20 but maybe it would be useful for Java 21 users (since it's LTS). But your new native extensions are targeting 22, so this can remain in Java 22 too. |
|
LGTM. Ship it! |
|
(pushing the button since i want to put this in beta3) |
I'd prefer this to be in
jvector-twentymodule. But--enable-previewflag is only allowed for the Java release version used to compile the code. When building with Java 22,--enable-previewis not allowed ontwentymodule because it builds for Java 20.Closes #278