Skip to content

Commit 28f5cc8

Browse files
authored
Merge pull request #2116 from sumanthsuresh1117/hd-ha-mw-fix
Remove check on snapshot create support for multi-writer HyperDisk-HA
2 parents b8b0251 + 6760775 commit 28f5cc8

File tree

2 files changed

+0
-21
lines changed

2 files changed

+0
-21
lines changed

pkg/gce-pd-csi-driver/controller.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1620,9 +1620,6 @@ func (gceCS *GCEControllerServer) CreateSnapshot(ctx context.Context, req *csi.C
16201620
}
16211621
return nil, common.LoggedError("CreateSnapshot, failed to getDisk: ", err)
16221622
}
1623-
if common.IsHyperdisk(disk.GetPDType()) && disk.GetAccessMode() == common.GCEReadWriteManyAccessMode {
1624-
return nil, status.Errorf(codes.InvalidArgument, "Cannot create snapshot for disk type %s with access mode %s", common.DiskTypeHdHA, common.GCEReadWriteManyAccessMode)
1625-
}
16261623

16271624
snapshotParams, err := common.ExtractAndDefaultSnapshotParameters(req.GetParameters(), gceCS.Driver.name, gceCS.Driver.extraTags)
16281625
if err != nil {

pkg/gce-pd-csi-driver/controller_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -265,24 +265,6 @@ func TestCreateSnapshotArguments(t *testing.T) {
265265
ReadyToUse: false,
266266
},
267267
},
268-
{
269-
name: "fail to create snapshot for HdHA multi-writer",
270-
req: &csi.CreateSnapshotRequest{
271-
Name: name,
272-
SourceVolumeId: testRegionalID,
273-
Parameters: map[string]string{common.ParameterKeyStorageLocations: " US-WEST2"},
274-
},
275-
seedDisks: []*gce.CloudDisk{
276-
gce.CloudDiskFromV1(&compute.Disk{
277-
Name: name,
278-
SelfLink: fmt.Sprintf("https://www.googleapis.com/compute/v1/projects/project/regions/country-region/name/%s", name),
279-
Type: common.DiskTypeHdHA,
280-
AccessMode: common.GCEReadWriteManyAccessMode,
281-
Region: "country-region",
282-
}),
283-
},
284-
expErrCode: codes.InvalidArgument,
285-
},
286268
}
287269

288270
for _, tc := range testCases {

0 commit comments

Comments
 (0)