Add "breakpoint created/deleted" notifications.

[vadimcn]

Some debuggers have much more flexible ways of setting breakpoints than VSCode currently supports (e.g. set breakpoints by regex). Would be nice if breakpoints created via commands in debugger console were reflected in the UI.

I'd suggest adding a new notification message to the protocol, which adapter can send when a breakpoint is created/deleted. It should include a "cookie" that needs to be passed back to the adapter in order to re-create the breakpoint.

[weinand]

@vadimcn the protocol has already a BreakpointEvent for this. Please see: https://github.com/Microsoft/vscode-debugadapter-node/blob/master/protocol/src/debugProtocol.ts#L135

@isidorn are you already tracking this event?

[isidorn]

@weinand yes here

[vadimcn]

@weinand: But does VSCode support creation/deleteion? Sending a BreakpointEvent with reason = 'new' doesn't seem to have any effect.
Your comment from February says "VS Code now listens on breakpoint events with reason update and updates the verification state and location". If I read the relevant code, correctly, it indeed only deals with updates of existing breakpoints.

[vadimcn]

Also, please note that currently the Breakpoint does not provide a way to preserve custom information (such as condition, hit count, etc) across debugging sessions.

[isidorn]

@vadimcn you are right, there is no code for dealing with Breakpoint event = 'new' or 'deleted' (@weinand do we want to call this 'deleted'?). Thus reopening this

[isidorn]

Assigning first to @weinand since this needs a couple of more additions to the protocol:

• How do we call an event when a breakpoint got deleted?
• Do we add a possibility that a adapter can also add / remove function breakpoints - if yes we need a way to distinguish those events from adding/removing regular breakpoints
• As mentioned by @vadimcn currently it is not possible for the debug adapter to send a breakpoint with a condition to vscode, so we might need to introduce the condition to the Breakpoint interface in the debug protocol

Once that is done we just need to handle those events here for which a pull request is welcome @vadimcn.