diff --git a/CHANGELOG.md b/CHANGELOG.md index c80391b320036..6574ef50b140e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ +## [1.14.2](https://github.com/n8n-io/n8n/compare/n8n@1.14.1...n8n@1.14.2) (2023-10-26) + + +### Bug Fixes + +* **core:** Handle missing resultData in runData ([#7523](https://github.com/n8n-io/n8n/issues/7523)) ([a35d5f1](https://github.com/n8n-io/n8n/commit/a35d5f1b4c10082a68b3ee6943e13a174f9fe471)) + + + ## [1.14.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.14.1) (2023-10-26) diff --git a/package.json b/package.json index 6f2cab2efa996..41eba7f002fda 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "n8n", - "version": "1.14.1", + "version": "1.14.2", "private": true, "homepage": "https://n8n.io", "engines": { diff --git a/packages/cli/package.json b/packages/cli/package.json index c8673f9fa7040..0fe0e6e39a8f8 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -1,6 +1,6 @@ { "name": "n8n", - "version": "1.14.1", + "version": "1.14.2", "description": "n8n Workflow Automation Tool", "license": "SEE LICENSE IN LICENSE.md", "homepage": "https://n8n.io", diff --git a/packages/cli/src/WorkflowRunner.ts b/packages/cli/src/WorkflowRunner.ts index 3483bb180587d..00cb4391539ba 100644 --- a/packages/cli/src/WorkflowRunner.ts +++ b/packages/cli/src/WorkflowRunner.ts @@ -70,8 +70,8 @@ export class WorkflowRunner { /** * The process did send a hook message so execute the appropriate hook */ - processHookMessage(workflowHooks: WorkflowHooks, hookData: IProcessMessageDataHook) { - void workflowHooks.executeHookFunctions(hookData.hook, hookData.parameters); + async processHookMessage(workflowHooks: WorkflowHooks, hookData: IProcessMessageDataHook) { + await workflowHooks.executeHookFunctions(hookData.hook, hookData.parameters); } /** @@ -772,7 +772,7 @@ export class WorkflowRunner { workflowHooks, ); } else if (message.type === 'processHook') { - this.processHookMessage(workflowHooks, message.data as IProcessMessageDataHook); + await this.processHookMessage(workflowHooks, message.data as IProcessMessageDataHook); } else if (message.type === 'timeout') { // Execution timed out and its process has been terminated const timeoutError = new WorkflowOperationError('Workflow execution timed out!'); diff --git a/packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts b/packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts index 113bb2980a9af..958c21181a0d6 100644 --- a/packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts +++ b/packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts @@ -11,7 +11,7 @@ export function determineFinalExecutionStatus(runData: IRun): ExecutionStatus { const workflowHasCrashed = runData.status === 'crashed'; const workflowWasCanceled = runData.status === 'canceled'; const workflowDidSucceed = - !runData.data.resultData.error && !workflowHasCrashed && !workflowWasCanceled; + !runData.data.resultData?.error && !workflowHasCrashed && !workflowWasCanceled; let workflowStatusFinal: ExecutionStatus = workflowDidSucceed ? 'success' : 'failed'; if (workflowHasCrashed) workflowStatusFinal = 'crashed'; if (workflowWasCanceled) workflowStatusFinal = 'canceled';