Skip to content

Add back test coverage from missing tests #33978

Open
@peppy

Description

@peppy

This recent PR removed song select v1 tests. Some tests don't have coverage in the new song select's test classes.

We should go through each one and decide whether they need to be added back.

diff --git a/test_comparison b/test_comparison
index e66df27cc2..8c57a07f8f 100644
--- a/test_comparison
+++ b/test_comparison
@@ -1,46 +1,25 @@
-TestScenePlaySongSelect
+TestSceneSongSelect
 
-TestAudioRemainsCorrectOnRulesetChange(bool rulesetsInSameBeatmap)
-TestAudioResuming()
 TestAutoplayShortcut()
 TestAutoplayShortcutKeepsAutoplayIfSelectedAlready()
 TestAutoplayShortcutReturnsInitialModsOnExit()
-TestBeatmapOptionsDisabled()
-TestCarouselSelectionUpdatesOnResume()
-TestChangeBeatmapAfterEnter()
-TestChangeBeatmapBeforeEnter()
-TestChangeBeatmapViaMouseAfterEnter()
-TestChangeBeatmapViaMouseBeforeEnter()
-TestChangeBeatmapWhilePresentingScore()
-TestChangeRulesetWhilePresentingScore()
-TestChangingRulesetOnMultiRulesetBeatmap()
-TestCutInFilterTextBox()
+TestClearModsViaModButtonRightClick()
+TestCookieDoesNothingIfNothingSelected()
 TestDeleteHotkey()
-TestDifficultyIconSelecting()
-TestDifficultyIconSelectingForDifferentRuleset()
-TestDummy()
-TestExternalBeatmapChangeWhileFiltered(bool differentRuleset)
-TestExternalBeatmapChangeWhileFilteredThenRefilter()
-TestFilterOnResumeAfterChange()
-TestFilterableModChange()
-TestGroupedDifficultyIconSelecting()
-TestHardDeleteHandledCorrectly()
-TestHideSetSelectsCorrectBeatmap()
-TestImportUnderCurrentRuleset()
-TestImportUnderDifferentRuleset()
-TestModOverlayToggling()
-TestModsRetainedBetweenSongSelect()
-TestNoFilterOnSimpleResume()
-TestNonFilterableModChange()
-TestPlaceholderBeatmapPresence()
-TestPlaceholderConvertSetting()
-TestPlaceholderStarDifficulty()
-TestPresentNewBeatmapNewRuleset()
-TestPresentNewRulesetNewBeatmap()
-TestSearchTextWithRulesetCriteria()
-TestSelectionRetainedOnBeatmapUpdate()
-TestSingleFilterOnEnter()
-TestSorting()
+TestFooterModOverlay()
+TestFooterMods()
+TestFooterOptions()
+TestFooterOptionsState()
+TestFooterRandom()
+TestFooterRandomViaMouse()
+TestFooterRewind()
+TestFooterRewindViaMouseRight()
+TestFooterRewindViaShiftMouseLeft()
+TestInvalidRulesetDoesNotEnterGameplay()
+TestModSelectCannotBeOpenedAfterConfirmingSelection()
+TestResultsScreenWhenClickingLeaderboardScore()
+TestSelectAfterDeletion()
+TestSelectionChangedFromProtectedToNone()
+TestSelectionChangedFromProtectedToSomething()
+TestSingleFilterWhenEntering()
 TestSpeedChange()
-TestStartAfterUnMatchingFilterDoesNotStart()
-TestTextBoxBeatmapDifficultyCount()

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions