3.12 support and no setuptools/wheel on 3.12+ - #2558
Merged
Conversation
chrysle
force-pushed
the
no-install-setuptools-wheel
branch
2 times, most recently
from
April 25, 2023 15:19
bf4f053 to
a119ed8
Compare
gaborbernat
requested changes
Apr 25, 2023
Contributor
Author
|
Thanks for the review. Updated. |
gaborbernat
requested changes
Apr 26, 2023
gaborbernat
left a comment
Contributor
There was a problem hiding this comment.
You also need a test.
Contributor
Author
|
Will look into this. Sorry for producing so much review work. |
chrysle
force-pushed
the
no-install-setuptools-wheel
branch
from
April 27, 2023 13:36
fc6a7d3 to
a0390e7
Compare
gaborbernat
force-pushed
the
no-install-setuptools-wheel
branch
6 times, most recently
from
April 27, 2023 17:18
678f07b to
343d855
Compare
Contributor
|
Ah this will get complicated, I'll take it from here 👍 |
Contributor
Author
|
Thank you! I'll try to be more help next time. |
gaborbernat
force-pushed
the
no-install-setuptools-wheel
branch
2 times, most recently
from
April 27, 2023 17:39
d4b72cc to
585ec87
Compare
gaborbernat
force-pushed
the
no-install-setuptools-wheel
branch
11 times, most recently
from
April 27, 2023 22:16
b97cd7c to
8e24910
Compare
gaborbernat
force-pushed
the
no-install-setuptools-wheel
branch
2 times, most recently
from
April 27, 2023 22:21
eccb0bd to
54159a5
Compare
gaborbernat
approved these changes
Apr 27, 2023
gaborbernat
force-pushed
the
no-install-setuptools-wheel
branch
2 times, most recently
from
April 27, 2023 22:43
1507527 to
b5a9506
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
gaborbernat
force-pushed
the
no-install-setuptools-wheel
branch
from
April 27, 2023 22:45
b5a9506 to
deabc5b
Compare
hroncok
pushed a commit
to fedora-python/virtualenv
that referenced
this pull request
Apr 28, 2023
Cherry-picked from fd93dd7
hroncok
pushed a commit
to fedora-python/virtualenv
that referenced
this pull request
Apr 28, 2023
Cherry-picked from fd93dd7
hroncok
pushed a commit
to fedora-python/virtualenv
that referenced
this pull request
Apr 28, 2023
Cherry-picked from fd93dd7
tarpas
pushed a commit
to tarpas/virtualenv
that referenced
this pull request
Jun 8, 2023
SpecLad
added a commit
to SpecLad/pip
that referenced
this pull request
Jul 6, 2023
…thon 3.12+ Due to the advent of build isolation, it is no longer necessary to install setuptools and wheel in an environment just to install other packages. Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop installing setuptools & wheel by default. This means that when those packages are present in a Python 3.12+ environment, it is reasonable to assume that they are runtime dependencies of the user's project, and therefore should be included in freeze output. distribute is just obsolete. [1] python/cpython#95299 [2] pypa/virtualenv#2558
yselkowitz
added a commit
to yselkowitz/pytest-venv
that referenced
this pull request
Jul 9, 2023
virtualenv 20.23.0 will no longer install setuptools and wheel by default when run with Python 3.12: pypa/virtualenv#2558 This causes the pkg_resources call in pytest-venv to fail, as that is installed together with setuptools. Use the virtualenv command line argument to restore the previous behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note this is my first little code contribution, so please be patient. Closes #2487
tox -e fix)docs/changelogfolder