bump python-discovery minimum to 1.2.2 - #3117
Merged
gaborbernat merged 3 commits intoApr 13, 2026
Merged
Conversation
rahuldevikar
marked this pull request as ready for review
April 13, 2026 20:33
gaborbernat
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a fix for this: https://github.com/python-lz4/python-lz4/actions/runs/24358045293/job/71130129933?pr=337
virtualenv requires python-discovery>=1 which is too loose — it happily accepts 1.2.0. When cibuildwheel's constraints file pins an old version, pip sees no conflict with virtualenv's requirement and downgrades it.
If virtualenv bumped its minimum to python-discovery>=1.2.2, pip would reject the downgrade to 1.2.0 because it would violate virtualenv's dependency. The constraints file can't override a hard requirement from an installed package.
This would fix the issue at the root — virtualenv is the package that brings in python-discovery, so it should declare the minimum version it (and its ecosystem) actually needs.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder