Skip to content

bump python-discovery minimum to 1.2.2 - #3117

Merged
gaborbernat merged 3 commits into
pypa:mainfrom
rahuldevikar:fix/bump-python-discovery-min-version
Apr 13, 2026
Merged

bump python-discovery minimum to 1.2.2#3117
gaborbernat merged 3 commits into
pypa:mainfrom
rahuldevikar:fix/bump-python-discovery-min-version

Conversation

@rahuldevikar

@rahuldevikar rahuldevikar commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Following a fix for this: https://github.com/python-lz4/python-lz4/actions/runs/24358045293/job/71130129933?pr=337

virtualenv requires python-discovery>=1 which is too loose — it happily accepts 1.2.0. When cibuildwheel's constraints file pins an old version, pip sees no conflict with virtualenv's requirement and downgrades it.

If virtualenv bumped its minimum to python-discovery>=1.2.2, pip would reject the downgrade to 1.2.0 because it would violate virtualenv's dependency. The constraints file can't override a hard requirement from an installed package.

This would fix the issue at the root — virtualenv is the package that brings in python-discovery, so it should declare the minimum version it (and its ecosystem) actually needs.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@rahuldevikar
rahuldevikar marked this pull request as ready for review April 13, 2026 20:33
@gaborbernat
gaborbernat merged commit 33348d6 into pypa:main Apr 13, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants