Skip to content

Commit a2e6d4b

Browse files
luke-hillbarancev
authored andcommitted
Remove python top level class method which is never included or extended
Alter rakefile order, remove uncalled requires and add comments about each section of requires
1 parent 341dc6e commit a2e6d4b

File tree

6 files changed

+2
-64
lines changed

6 files changed

+2
-64
lines changed

Rakefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ require 'rake_tasks/crazy_fun/main'
1919
require 'rake_tasks/selenium_rake/detonating_handler'
2020
require 'rake_tasks/selenium_rake/crazy_fun'
2121

22+
# The CrazyFun builders - Most of these are either partially or fully obsolete
2223
require 'rake_tasks/crazy_fun/mappings/tasks'
2324
require 'rake_tasks/crazy_fun/mappings/javascript'
2425
require 'rake_tasks/crazy_fun/mappings/rake'
25-
require 'rake_tasks/crazy_fun/mappings/rename'
2626
require 'rake_tasks/crazy_fun/mappings/ruby'
2727

2828
# Location of all new methods
@@ -36,8 +36,7 @@ require 'rake_tasks/selenium_rake/type_definitions_generator'
3636
require 'rake_tasks/rake/task'
3737
require 'rake_tasks/rake/dsl'
3838

39-
# Require the migrated rake files, which need to be tidied up further
40-
# These are the final items mixed into the global NS
39+
# These are the final items mixed into the global NS, should be namespaced correctly
4140
require 'rake_tasks/bazel'
4241
require 'rake_tasks/copyright'
4342
require 'rake_tasks/python'
Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1 @@
11
require 'rake_tasks/selenium_rake/checks'
2-
3-
module Python
4-
def self.lib_dir
5-
Dir.glob('build/lib*')[0] || 'build/lib'
6-
end
7-
end

rake_tasks/crazy_fun/mappings/rename/add_dependencies.rb

Lines changed: 0 additions & 12 deletions
This file was deleted.

rake_tasks/crazy_fun/mappings/rename/check_preconditions.rb

Lines changed: 0 additions & 9 deletions
This file was deleted.

rake_tasks/crazy_fun/mappings/rename/export.rb

Lines changed: 0 additions & 21 deletions
This file was deleted.

rake_tasks/crazy_fun/mappings/rename_mappings.rb

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)