Skip to content

Commit dee4d74

Browse files
amrkk123imrannayer
andauthored
chore: Change description for tier in mysql and cloud sql (#724)
Co-authored-by: Imran Nayer <[email protected]>
1 parent 056e436 commit dee4d74

File tree

6 files changed

+14
-6
lines changed

6 files changed

+14
-6
lines changed

modules/mysql/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ module "mysql-db" {
9898
| replica\_database\_version | The read replica database version to use. This var should only be used during a database update. The update sequence 1. read-replica 2. master, setting this to an updated version will cause the replica to update, then you may update the master with the var database\_version and remove this field after update is complete | `string` | `""` | no |
9999
| root\_password | MySQL password for the root user. | `string` | `null` | no |
100100
| secondary\_zone | The preferred zone for the secondary/failover instance, it should be something like: `us-central1-a`, `us-east1-c`. | `string` | `null` | no |
101-
| tier | The tier for the master instance. | `string` | `"db-n1-standard-1"` | no |
101+
| tier | The tier for the master instance, for ADC its defualt value will be db-perf-optimized-N-8 which is tier value for edtion ENTERPRISE\_PLUS, if user wants to change the edition, he should chose compatible tier. | `string` | `"db-n1-standard-1"` | no |
102102
| update\_timeout | The optional timout that is applied to limit long database updates. | `string` | `"30m"` | no |
103103
| user\_deletion\_policy | The deletion policy for the user. Setting ABANDON allows the resource to be abandoned rather than deleted. This is useful for Postgres, where users cannot be deleted from the API if they have been granted SQL roles. Possible values are: "ABANDON". | `string` | `null` | no |
104104
| user\_host | The host for the default user | `string` | `"%"` | no |

modules/mysql/metadata.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ spec:
186186
description: Users can upgrade a read replica instance to a stand-alone Cloud SQL instance with the help of instance_type. To promote, users have to set the instance_type property as CLOUD_SQL_INSTANCE and remove/unset master_instance_name and replica_configuration from instance configuration. This operation might cause your instance to restart.
187187
varType: string
188188
- name: tier
189-
description: The tier for the master instance.
189+
description: The tier for the master instance, for ADC its defualt value will be db-perf-optimized-N-8 which is tier value for edtion ENTERPRISE_PLUS, if user wants to change the edition, he should chose compatible tier.
190190
varType: string
191191
defaultValue: db-n1-standard-1
192192
- name: zone
@@ -912,6 +912,7 @@ spec:
912912
- level: Project
913913
roles:
914914
- roles/cloudkms.admin
915+
- roles/cloudkms.autokeyAdmin
915916
- roles/cloudkms.cryptoKeyEncrypterDecrypter
916917
- roles/cloudscheduler.admin
917918
- roles/cloudsql.admin

modules/mysql/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ variable "instance_type" {
178178

179179
// Master
180180
variable "tier" {
181-
description = "The tier for the master instance."
181+
description = "The tier for the master instance, for ADC its defualt value will be db-perf-optimized-N-8 which is tier value for edtion ENTERPRISE_PLUS, if user wants to change the edition, he should chose compatible tier."
182182
type = string
183183
default = "db-n1-standard-1"
184184
}

modules/postgresql/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ module "pg" {
169169
| region | The region of the Cloud SQL resources | `string` | `"us-central1"` | no |
170170
| root\_password | Initial root password during creation | `string` | `null` | no |
171171
| secondary\_zone | The preferred zone for the replica instance, it should be something like: `us-central1-a`, `us-east1-c`. | `string` | `null` | no |
172-
| tier | The tier for the Cloud SQL instance. | `string` | `"db-f1-micro"` | no |
172+
| tier | The tier for the Cloud SQL instance, for ADC its defualt value will be db-perf-optimized-N-8 which is tier value for edtion ENTERPRISE\_PLUS, if user wants to change the edition, he should chose compatible tier. | `string` | `"db-f1-micro"` | no |
173173
| update\_timeout | The optional timout that is applied to limit long database updates. | `string` | `"30m"` | no |
174174
| use\_autokey | Enable the use of autokeys from Google Cloud KMS for CMEK. This requires autokey already configured in the project. | `bool` | `false` | no |
175175
| user\_deletion\_policy | The deletion policy for the user. Setting ABANDON allows the resource to be abandoned rather than deleted. This is useful for Postgres, where users cannot be deleted from the API if they have been granted SQL roles. Possible values are: "ABANDON". | `string` | `null` | no |

modules/postgresql/metadata.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ spec:
163163
varType: bool
164164
defaultValue: false
165165
- name: tier
166-
description: The tier for the Cloud SQL instance.
166+
description: The tier for the Cloud SQL instance, for ADC its defualt value will be db-perf-optimized-N-8 which is tier value for edtion ENTERPRISE_PLUS, if user wants to change the edition, he should chose compatible tier.
167167
varType: string
168168
defaultValue: db-f1-micro
169169
- name: zone
@@ -404,7 +404,13 @@ spec:
404404
description: The roles required by default database instance service account for integration with GCP services
405405
varType: list(string)
406406
defaultValue: []
407+
- name: use_autokey
408+
description: Enable the use of autokeys from Google Cloud KMS for CMEK. This requires autokey already configured in the project.
409+
varType: bool
410+
defaultValue: false
407411
outputs:
412+
- name: additional_user_passwords_map
413+
description: Map of auto generated passwords for the additional users
408414
- name: additional_users
409415
description: List of maps of additional users and passwords
410416
type:
@@ -902,6 +908,7 @@ spec:
902908
- level: Project
903909
roles:
904910
- roles/cloudkms.admin
911+
- roles/cloudkms.autokeyAdmin
905912
- roles/cloudkms.cryptoKeyEncrypterDecrypter
906913
- roles/cloudscheduler.admin
907914
- roles/cloudsql.admin

modules/postgresql/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ variable "random_instance_name" {
171171
}
172172

173173
variable "tier" {
174-
description = "The tier for the Cloud SQL instance."
174+
description = "The tier for the Cloud SQL instance, for ADC its defualt value will be db-perf-optimized-N-8 which is tier value for edtion ENTERPRISE_PLUS, if user wants to change the edition, he should chose compatible tier."
175175
type = string
176176
default = "db-f1-micro"
177177
}

0 commit comments

Comments
 (0)