feat: design token and theme package documentation#103
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://paste-git-feat-theme-package-docs.twilio-dsys.now.sh |
aayushpi
left a comment
There was a problem hiding this comment.
Some text suggestions for clarity and approachability.
|
@aayushpi if you want to give it a pass I've done a once through now |
| </SiteNavItem> | ||
| <SiteNavItem> | ||
| <SiteNavAnchor to={`${SidebarCategoryRoutes.TOKENS}/how-to-compose-custom-ui-with-tokens`}> | ||
| How to compose custom UI with tokens |
There was a problem hiding this comment.
There was a problem hiding this comment.
Seems like an improvement to me but I'll wait for a consensus before changing it as it involves changing filenames and stuff and there maybe other ideas. @aayushpi @serifluous @two24studios for input
|
|
||
| ## The happy path | ||
|
|
||
| Obviously the first option is to work with your design partner and identify all the existing Paste components that can be used to create the experience. If you are struggling or have quesitons come to Design System Office Hours or post in the #help-design-system slack channel, we'll get you back on track. |
There was a problem hiding this comment.
Should we link to info on Office Hours?
There was a problem hiding this comment.
Should we link to info on Office Hours?
Do we have a link?
| {`<Box padding="space20"> | ||
| <Text as="p" marginBottom="space40">Some text</Text> | ||
| <Text as="h1" fontSize="fontSize70" fontWeight="fontWeightMedium" lineHeight="lineHeight70" mb="space80">Custom heading</Text> | ||
| <Text as="ul" ml="space60"> |
There was a problem hiding this comment.
Should this be a Text or a Box?
If we're making it a Text, can we pass the fontSize to it and would the children elements receive the styling?
There was a problem hiding this comment.
So Text right now has a set default font-size, which matches what the system classes as the default body size. The reason being is that we font set a body size as you can't really override someone's application, and we don't actually know where this will be used so can't rely on any inheritance.
So even if I did set it on the ul, it won't currently affect the children as they set their own font-size anyway.
There was a problem hiding this comment.
Makes sense. Is there any guidelines or issues with making a ul element a Text as opposed to a Box though?
1559149 to
93ee7b7
Compare
|
One down, three to go - design tokens package is edited |
|
Added:
|
Add a page for each of the Design Token package and Theme package, with install instructions and how to use. Similar to a component or utility page.
Contributing to Twilio