[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants |
|
Date: |
Tue, 25 Aug 2020 12:08:44 +0100 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Aug 19, 2020 at 08:11:44PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros:
>
> ASPEED_GPIO
> ASPEED_I2C
> ASPEED_RTC
> ASPEED_SCU
> ASPEED_SDHCI
> ASPEED_SDMC
> ASPEED_VIC
> ASPEED_WDT
> ASPEED_XDMA
>
> This needs to be addressed to allow us to transform the QOM type
> check macros into functions generated by OBJECT_DECLARE_TYPE().
>
> Rename all the constants to ASPEED_DEV_*, to avoid conflicts.
>
> Signed-off-by: Eduardo Habkost <[email protected]>
> ---
> Changes v1 -> v2:
> * Added more details to commit message
>
> ---
> Cc: "Cédric Le Goater" <[email protected]>
> Cc: Peter Maydell <[email protected]>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Joel Stanley <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> include/hw/arm/aspeed_soc.h | 92 +++++++--------
> hw/arm/aspeed.c | 4 +-
> hw/arm/aspeed_ast2600.c | 208 ++++++++++++++++----------------
> hw/arm/aspeed_soc.c | 228 ++++++++++++++++++------------------
> 4 files changed, 266 insertions(+), 266 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 04/58] pl110: Rename pl110_version enum values, (continued)
- [PATCH v2 04/58] pl110: Rename pl110_version enum values, Eduardo Habkost, 2020/08/19
- [PATCH v2 02/58] megasas: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 03/58] vmw_pvscsi: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 05/58] allwinner-h3: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 08/58] sifive_e: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 07/58] opentitan: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 09/58] sifive_u: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition, Eduardo Habkost, 2020/08/19
- [PATCH v2 11/58] versatile: Fix typo in PCI_VPB_HOST definition, Eduardo Habkost, 2020/08/19
- [PATCH v2 12/58] virtio-ccw: Fix definition of VIRTIO_CCW_BUS_GET_CLASS, Eduardo Habkost, 2020/08/19