[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Trivial: 3 char repeat typos
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] Trivial: 3 char repeat typos |
|
Date: |
Mon, 23 May 2022 11:13:54 +0100 |
On Mon, 23 May 2022 at 11:09, Dr. David Alan Gilbert (git)
<[email protected]> wrote:
>
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> Inspired by Julia Lawall's fixing of Linux
> kernel comments, I looked at qemu, although I did it manually.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Checkpatch would probably ask you to fix up some of the comment
styles when you touch some of these. Either way:
Reviewed-by: Peter Maydell <[email protected]>
> diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
> index 04427e073f..2467c5bf76 100644
> --- a/target/arm/cpu64.c
> +++ b/target/arm/cpu64.c
> @@ -997,7 +997,7 @@ static void aarch64_a64fx_initfn(Object *obj)
> cpu->gic_vpribits = 5;
> cpu->gic_vprebits = 5;
>
> - /* Suppport of A64FX's vector length are 128,256 and 512bit only */
> + /* Support of A64FX's vector length are 128,256 and 512bit only */
This one came up in review of a different patch that happened to touch
this function. We should ideally rephrase it to fix all of the typo, the
missing space after comma and the unnatural grammar:
/* The A64FX supports only 128, 256 and 512 bit vector lengths */
thanks
-- PMM