[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug Report] Possible Missing Endianness Conversion
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [Bug Report] Possible Missing Endianness Conversion |
|
Date: |
Mon, 24 Jun 2024 17:10:27 +0200 |
CCing Jason.
On Mon, Jun 24, 2024 at 4:30 PM Xoykie <[email protected]> wrote:
>
> The virtio packed virtqueue support patch[1] suggests converting
> endianness by lines:
>
> virtio_tswap16s(vdev, &e->off_wrap);
> virtio_tswap16s(vdev, &e->flags);
>
> Though both of these conversion statements aren't present in the
> latest qemu code here[2]
>
> Is this intentional?
Good catch!
It looks like it was removed (maybe by mistake) by commit
d152cdd6f6 ("virtio: use virtio accessor to access packed event")
Jason can you confirm that?
Thanks,
Stefano
>
> [1]: https://mail.gnu.org/archive/html/qemu-block/2019-10/msg01492.html
> [2]: https://elixir.bootlin.com/qemu/latest/source/hw/virtio/virtio.c#L314
>