xdsclient: fix race in load report implementation#5927
Merged
Conversation
dfawley
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
clientImpl.ReportLoad(), once we get a reference to the appropriateauthorityobject, we are supposed to increment the reference count using a call toauthority.refLocked().The documentation on this function says:
// Increments the reference count. Caller must hold parent's authorityMu.We were releasing the mutex right before incrementing the reference count, and this was not caught by any of our unit tests. It was only caught when I ran a prober binary with the race flag enabled.
RELEASE NOTES: