fix(rds): support autonaming for instance identifiers - #6437
Merged
Conversation
Summary: - Move RDS instance identifier defaulting to ComputeDefault with AutoNamed. - Preserve legacy generated-name shape, SQL Server suffix length, and prior-state reuse. - Add provider, preview, prefix-conflict, and upgrade coverage for Pulumi autonaming config. Rationale: - The old DefaultInfo.From path could not honor pulumi:autonaming configuration. Using ComputeAutoNameDefault lets the bridge apply configured autonaming while retaining prior identifiers during provider upgrades. - identifierPrefix is already handled by the bridge's generic Terraform ConflictsWith default-suppression path, so no provider-specific guard is needed. Tests: - make provider - make test_provider test_provider_cmd="cd provider && go test -p=1 -vet=off -v -short -run TestRdsInstanceIdentifierAutonaming -count=1 ." - make test TESTTAGS=java TESTPARALLELISM=1 GOTESTARGS="-run \"^TestRdsInstance(Autonaming|IdentifierPrefixSuppressesAutonaming)$\" -count=1" - esc run pulumi/providers/aws -- make test TESTTAGS=java TESTPARALLELISM=1 GOTESTARGS="-run ^TestRdsInstanceAutonamingUpgrade$ -count=1" - git diff --check Co-authored-by: Codex <codex@openai.com>
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6437 +/- ##
==========================================
+ Coverage 14.74% 15.98% +1.24%
==========================================
Files 373 374 +1
Lines 89585 91298 +1713
==========================================
+ Hits 13209 14596 +1387
- Misses 76354 76682 +328
+ Partials 22 20 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
corymhall
marked this pull request as ready for review
June 16, 2026 09:42
Contributor
There was a problem hiding this comment.
No actionable issues found.
Reviewed by Internal Trusted PR Reviewer
Add this agentic workflows to your repo
To install this agentic workflow, run
gh aw add pulumi-labs/gh-aw-internal/.github/workflows/gh-aw-pr-review.md@8a92f53fac170563f7727cacab2dbedb5d5b9e29
pose
approved these changes
Jun 16, 2026
Contributor
|
This PR has been shipped in release v7.34.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates
aws:rds/instance:Instanceso the generatedidentifierdefault participates in Pulumi autonaming configuration.The RDS identifier default now uses
ComputeDefaultwithAutoNamed: trueand delegates totfbridge.ComputeAutoNameDefault. This preserves the previous fallback naming shape, including the shorter SQL Server suffix, while allowingpulumi:autonamingpatterns and modes to apply.Compatibility
Existing resources should keep their prior identifier during provider upgrades because
ComputeAutoNameDefaultreuses the prior value when prior state is available. The upgrade fixture covers a baseline stack created byv6.78.0and previews it with the new provider.identifierPrefixremains a separate explicit naming mechanism. There is no provider-specific prefix guard here: the bridge's generic TerraformConflictsWithhandling suppresses theidentifierdefault whenidentifierPrefixis present. The PR includes a preview/gRPC assertion for that path.Tests
make providermake test_provider test_provider_cmd="cd provider && go test -p=1 -vet=off -v -short -run TestRdsInstanceIdentifierAutonaming -count=1 ."make test TESTTAGS=java TESTPARALLELISM=1 GOTESTARGS="-run \"^TestRdsInstance(Autonaming|IdentifierPrefixSuppressesAutonaming)$\" -count=1"make test TESTTAGS=java TESTPARALLELISM=1 GOTESTARGS="-run ^TestRdsInstanceAutonamingUpgrade$ -count=1"git diff --checkNotes:
TestRdsInstanceAutonamingis preview-only and asserts the providerCheckresponse via gRPC log instead of creating a live RDS instance.TestRdsInstanceIdentifierPrefixSuppressesAutonamingprovesidentifierPrefixsuppresses theidentifierdefault through the bridge conflict path.TestRdsInstanceAutonamingUpgradeuses the recorded baseline stack to validate old-state compatibility.fixes #6434