Conversation
Closed
…iptor, similar to tmp.fileSync
raszi
requested changes
Feb 3, 2020
bc3dcab to
7ee5bdd
Compare
…private functions to the back of the module
Collaborator
Author
|
Future TODO
|
Collaborator
Author
|
darn windows build is now failing with a EBADF, investigating |
Collaborator
Author
|
fixed, needed YAWSWA (yet another windows specific work around) |
raszi
approved these changes
Feb 8, 2020
raszi
reviewed
Feb 10, 2020
|
|
||
| ## tmp v0.2.0 | ||
|
|
||
| - drop support for node version < v8.17.0 |
There was a problem hiding this comment.
is it ok to release it for v8 (as its working) and drop support in feature version?
Collaborator
Author
|
ATM I do not have time for this, started on a new job and have to get up to speed there first. |
7 tasks
Collaborator
Author
|
The travis-ci builds are no longer showing: |
Collaborator
Author
|
@raszi I think I am done with this PR. I fixed all the issues listed. You might want to have another look and if everything is ok, we can finally merge this and you can make a new 0.2.0 release 🚀 |
…so sanitize dir option, the template option and the name option
raszi
approved these changes
Apr 9, 2020
Owner
|
Nice work @silkentrance |
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO