Minor tweaks; prepare v0.10.0-rc.9#1736
Conversation
| run: cargo publish | ||
| env: | ||
| CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }} | ||
| - name: Publish rand |
There was a problem hiding this comment.
I don't think this change is needed. Just publish rand_pcg manually for now. For a multi-crate repository you should use a more involved config, e.g. see one from RustCrypto/traits.
There was a problem hiding this comment.
That requires a lot of distinct tags, and potentially that they are pushed in the right order.
This is simpler and works fine provided that all crates are released simultaneously under a single tag (good enough in that case, though I also publish a few patches by hand).
There was a problem hiding this comment.
potentially that they are pushed in the right order.
No, the tag order does not matter. The linked config works fine when you push several release tags to one commit simultaneously. The workflow is triggered separately for each pushed tag.
released simultaneously under a single tag
IMO it's a pretty bad restriction and you should use different tags for each crate release. Either way, I do not insist on the suggested approach, though I most certainly would not use your config in RustCrypto repositories.
There was a problem hiding this comment.
No, the tag order does not matter.
It would if the crates have any inter-depenencies... unless you just re-run the failures?
IMO it's a pretty bad restriction
It is, and is insufficient if all publishing must be done using Trusted Publishing.
On the other hand, RustCrypto/traits has 435 tags. I thought this repo was bad enough.
There was a problem hiding this comment.
It would if the crates have any inter-depenencies
Well, obviously if one crates depends on another inside the repo and we are doing breaking releases, crate releases should be properly sequenced and use different commits. But most repositories contain decoupled crates similarly to the RNGs repo and patch releases are more frequent of a crate than sweeping breaking release cycles.
On the other hand, RustCrypto/traits has 435 tags.
A significant number of those is caused by the recent unfortunate explosion of RCs (in hindsight we should've been more conservative with those). Since the tags have predictable structure of crate-name-vX.Y.Z they are easy to search and it's trivial to find exact commit for a crate release.
Either way, the current config is a complete non-starter if crates in repository could be released independently from each other. Arguably, it applies to the rand repo as well. I doubt you want to release new version of rand_pcg on a patch release of `rand. and vice versa.
IMO it would be easier to just move |
This was the plan. Logistically it's easier to wait until after the release. |
|
I forgot to enable Trusted Publishing for rand_pcg so had to publish that manually. It's enabled now. |
@newpavlov this includes a number of what I think are uncontroversial changes from my other PRs and also bumps versions to allow publishing a new pre-release.
I'm not committing to keeping rand_pcg in this repo but for now this is the easiest approach (I also wouldn't make changes here until after v0.10).