fix: parse forwarded header lists#1944
Merged
Merged
Conversation
Member
|
Thank you! @all-contributors please add @immanuwell for code |
Contributor
|
I've put up a pull request to add @immanuwell! 🎉 |
captain686
pushed a commit
to captain686/warpgate
that referenced
this pull request
May 29, 2026
Co-authored-by: Eugene <inbox@null.page>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles comma-separated
X-Forwarded-*values when trusted headers are on. Multi-hop proxies do this IRL, AWS ALB appends XFF by default, so yep this is reachable.Repro:
http.trust_x_forwarded_headers: trueX-Forwarded-Host: public.example, proxy.local,X-Forwarded-Proto: https, http, orX-Forwarded-For: 203.0.113.10, 10.0.0.2Tests:
cargo test -p warpgate-common-http;cargo clippy -p warpgate-common-http --all-targets -- -D warnings;cargo fmt --check --package warpgate-common-httpRelated: #882, #921, #886