Menu ▾ ▴

#175 sarg fails to build with GCC 10.3 - variables get redeclared (no extern)

v1.0_(example)
open
nobody
None
9
2021-06-22
2021-06-22
Sergio Durigan Junior
No

Hello,

sarg FTBFS in Ubuntu Impish (development version), which uses GCC 10.3 because of the way variables are declared inside include/conf.h.

It's a bad practice to declare variables inside a header file, because they get included as-is into the C file which means that the variables get redeclared on every compilation unit. Instead, these variables should be marked as "extern" and be declared inside a C file.

If you would like to see the build log with the compilation failure, you can go to:

https://launchpadlibrarian.net/544878407/buildlog_ubuntu-impish-amd64.sarg_2.4.0-1ubuntu3_BUILDING.txt.gz

Thanks.

Discussion

Log in to post a comment.