Add ToProto() method to all C# descriptor classes #9426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
approved these changes
Jan 28, 2022
Contributor
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM with one very minor nit.
|
|
||
| /// <summary> | ||
| /// Returns a clone of the underlying <see cref="EnumDescriptorProto"/> describing this enum. | ||
| /// Note that a copy is taken every time this method is called, so clients using it frequently |
Contributor
There was a problem hiding this comment.
nit: worth mentioning that a deep clone is taken? (which also explains why it's safe to to .Clone() internally since it provides a deep clone).
Same below.
Leaving resolution up to you - I don't feel strongly about this at all.
Contributor
Author
There was a problem hiding this comment.
Well it specifically says "Returns a clone" and "Note that a copy is taken" - I don't think we need to specifically say it's a deep clone, as a shallow clone would be really odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9425.