diff --git a/core/modules/language/src/Tests/Views/FilterLanguageTest.php b/core/modules/language/src/Tests/Views/FilterLanguageTest.php index 591ad17..b3cc5d8 100644 --- a/core/modules/language/src/Tests/Views/FilterLanguageTest.php +++ b/core/modules/language/src/Tests/Views/FilterLanguageTest.php @@ -45,6 +45,18 @@ public function testFilter() { 'name' => $name, )); $this->assertIdenticalResultset($view, $expected, array('views_test_data_name' => 'name')); + + $expected = [ + '***LANGUAGE_site_default***', + '***LANGUAGE_language_interface***', + '***LANGUAGE_language_content***', + 'en', + 'xx-lolspeak', + 'und', + 'zxx' + ]; + $this->assertIdentical(array_keys($view->filter['langcode']->getValueOptions()), $expected); + $view->destroy(); } } diff --git a/core/modules/user/src/Tests/Views/HandlerFilterPermissionTest.php b/core/modules/user/src/Tests/Views/HandlerFilterPermissionTest.php index b781f07..5cdf6b9 100644 --- a/core/modules/user/src/Tests/Views/HandlerFilterPermissionTest.php +++ b/core/modules/user/src/Tests/Views/HandlerFilterPermissionTest.php @@ -74,7 +74,6 @@ public function testFilterPermission() { $view->initDisplay(); $view->initHandlers(); - $view->filter['permission']->getValueOptions(); // Test the value options. $value_options = $view->filter['permission']->getValueOptions(); diff --git a/core/modules/user/src/Tests/Views/HandlerFilterRolesTest.php b/core/modules/user/src/Tests/Views/HandlerFilterRolesTest.php index b105583..6873a76 100644 --- a/core/modules/user/src/Tests/Views/HandlerFilterRolesTest.php +++ b/core/modules/user/src/Tests/Views/HandlerFilterRolesTest.php @@ -9,6 +9,7 @@ use Drupal\user\Entity\Role; use Drupal\views\Entity\View; +use Drupal\views\Views; /** * Tests the roles filter handler. @@ -52,6 +53,11 @@ public function testDependencies() { $expected['config'][] = 'user.role.test_user_role'; $this->assertEqual($expected, $view->getDependencies()); + $view = Views::getView('test_user_name'); + $view->initDisplay(); + $view->initHandlers(); + $this->assertEqual(array_keys($view->filter['roles_target_id']->getValueOptions()), ['test_user_role']); + $view = View::load('test_user_name'); $display = &$view->getDisplay('default'); $display['display_options']['filters']['roles_target_id'] = [ diff --git a/core/modules/user/src/Tests/Views/HandlerFilterUserNameTest.php b/core/modules/user/src/Tests/Views/HandlerFilterUserNameTest.php index 00bc8c0..2e1fc3e 100644 --- a/core/modules/user/src/Tests/Views/HandlerFilterUserNameTest.php +++ b/core/modules/user/src/Tests/Views/HandlerFilterUserNameTest.php @@ -83,6 +83,8 @@ public function testUserNameApi() { $this->executeView($view); $this->assertIdenticalResultset($view, array(array('uid' => $this->accounts[0]->id())), $this->columnMap); + + $this->assertEqual($view->filter['uid']->getValueOptions(), NULL); } /**