Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.VersioncontrolEntityController is a precursor to DrupalDefaultEntityController and quite a bit of code is the same. When working on #2168239: Store, and use, commit hashes of packaged projects, I got to a notice in VersioncontrolEntityController::cacheGet(). I tried this out in case it solved the issue, it did not; so this is only lightly tested.
This updates VersioncontrolEntityController::cacheGet() to match DrupalDefaultEntityController::cacheGet(). In the future, VersioncontrolEntityController might be replaced with DrupalDefaultEntityController, especially if this helps clean up for a D8 upgrade.
(My notice was with 'branches' in $conditions. Since that’s not a normal property, the conditions checking code wouldn’t work well. I worked around it by using the ['may cache' => FALSE] option.)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2761637.diff | 1.77 KB | drumm |
Comments
Comment #2
drummHere is the patch.
Comment #3
drummComment #5
marvil07 commentedI now only vaguely remember the differences between what @sdboyer introduced in 2010 during TGGM and what was on to-be-D7 at the time that was added to D6 versioncontrol :-)
Yes, the plan for D8 would be to reuse as much as possible from core; in D7 port we by-passed the re-use on purpose, but I do not remember those details neither now.
The change looks good, it's now included; thanks for the detailed explanation!