Drupal 9 compatibility

Patch applied cleanly and works on D9.

https://www.drupal.org/node/3070687

Class CMBase was not found while trying to analyse it - autoloading is probably not configured properly.

That in itself does not prove anything, the tool sometimes produces false positives. Did you try to use it with Drupal 9?

It seems this commit is breaking composer deployments for a lot of people: #3131746: Composer "Could not parse version constraint {version}" error

@meanderix is right. Please could you rollback this commit? seems that the composer is trying to download the very old module version that was failing with variable {version} in the composer.json.

Can it be that core: 8.x must be removed from info.yml ?

https://git.drupalcode.org/project/campaignmonitor/-/commit/9afe72d?view...

@davidarbour I think you are right and also, should be like this:

core_version_requirement: ^8.7.7 || ^9

https://www.drupal.org/node/3070687

I didn't test it either.

There is no reason to specify anything in the composer file in terms of core requirement, it will be taken from the info file. This helps with them not getting outdated.

@Gábor Hojtsy you are right, composer.json is fine. I've edited my previous comment. I think (didn't test it) only info.yml need to be changed to. Also, do what @davidarbour said
core_version_requirement: ^8.7.7 || ^9

I would like to have a bit more debugging information.

composer require drupal/campaignmonitor I'm getting

  [RuntimeException]                                                                                                                                                       
  Could not load package drupal/campaignmonitor in https://packages.drupal.org/8: [UnexpectedValueException] Could not parse version constraint {version}: Invalid version string "{version}"                                                                                                                                                     
                                                                                                                                                                           
                                
  [UnexpectedValueException]                                                        
  Could not parse version constraint {version}: Invalid version string "{version}"

After some investigation it seems like old releases are causing the issue.
https://packages.drupal.org/8/drupal/campaignmonitor%248295169748a199564...
{version} was placed in composer.json for the following releases

• 1.0.0-alpha2
• 1.0.0-beta1

@VladimirAus yeah, but why composer is trying to download other versions when we were asking ^2.0. Seems that composer is not installing the right version because it doesn't match with drupal core requirements.Could be something similar to this issue:

https://www.drupal.org/project/migrate_upgrade/issues/3008682#comment-12...

@lcontreras: it doesn't downloads previous versions. It downloads json manifest that contains errors passed from poorly defined composer.json for older versions.
Seems like those errors didn't kicked in until semantic versioning was switch on.

@VladimirAus thanks for the clarification!

Per a Slack discussion with Gábor Hojtsy last year regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing title and tag cleanup here based on that discussion. Please use "Drupal 9 compatibility" for titles and tags on other issues. Thanks.