Problem/Motivation
Behat Drupal Extension has deprecated subcontexts in favor of regular Behat context classes (ref. #518 Deprecate subcontexts).
Proposed resolution
Provide a new context class while remaining backwards compatible by moving all logic into a trait with is used by both the deprecated subcontext class and the new context class.
User interface changes
None.
API changes
Addition of a new MessageDigestContext class which is forwards compatible with Drupal Extension 5.x and beyond.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff.txt | 928 bytes | pfrenssen |
| #5 | 3168495-4.patch | 18.46 KB | pfrenssen |
Comments
Comment #2
pfrenssenHere is an initial attempt. Still needs to be tested, both to see if it still works in projects that use subcontexts, and in projects that have subcontexts disabled.
Comment #4
pfrenssenFixing coding standards violations. The test failure is unrelated to this patch.
I have tested the patch against a Drupal project that has subcontexts disabled and it is working as expected. I have also started a test against a project that is still using subcontexts to see that this doesn't cause any regressions. I will report back when the test results are in.
Comment #5
pfrenssenComment #7
pfrenssenOur test to check that this patch doesn't cause regressions has succeeded: https://github.com/ec-europa/joinup-dev/pull/2235
This is ready for review, the test failure is unrelated to these changes and is affecting all open issues.
Comment #9
jhedstromThanks! Sorry for the delay!