Problem/Motivation

Behat Drupal Extension has deprecated subcontexts in favor of regular Behat context classes (ref. #518 Deprecate subcontexts).

Proposed resolution

Provide a new context class while remaining backwards compatible by moving all logic into a trait with is used by both the deprecated subcontext class and the new context class.

User interface changes

None.

API changes

Addition of a new MessageDigestContext class which is forwards compatible with Drupal Extension 5.x and beyond.

Data model changes

None.

CommentFileSizeAuthor
#5 interdiff.txt928 bytespfrenssen
#5 3168495-4.patch18.46 KBpfrenssen
#2 3168495-2.patch18.31 KBpfrenssen

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

Assigned: Unassigned » pfrenssen
Status: Active » Needs review
StatusFileSize
new18.31 KB

Here is an initial attempt. Still needs to be tested, both to see if it still works in projects that use subcontexts, and in projects that have subcontexts disabled.

Status: Needs review » Needs work

The last submitted patch, 2: 3168495-2.patch, failed testing. View results

pfrenssen’s picture

Status: Needs work » Needs review

Fixing coding standards violations. The test failure is unrelated to this patch.

I have tested the patch against a Drupal project that has subcontexts disabled and it is working as expected. I have also started a test against a project that is still using subcontexts to see that this doesn't cause any regressions. I will report back when the test results are in.

pfrenssen’s picture

StatusFileSize
new18.46 KB
new928 bytes

Status: Needs review » Needs work

The last submitted patch, 5: 3168495-4.patch, failed testing. View results

pfrenssen’s picture

Assigned: pfrenssen » Unassigned
Status: Needs work » Needs review

Our test to check that this patch doesn't cause regressions has succeeded: https://github.com/ec-europa/joinup-dev/pull/2235

This is ready for review, the test failure is unrelated to these changes and is affecting all open issues.

  • jhedstrom committed f419657 on 8.x-1.x authored by pfrenssen
    Issue #3168495 by pfrenssen: MessageDigestSubcontext is deprecated
    
jhedstrom’s picture

Status: Needs review » Fixed

Thanks! Sorry for the delay!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.