Problem/Motivation

If you apply a recipe in Project Browser that has input, you are redirected away from Project Browser to a form where you need to fill out the inputs.

This was necessary before we fixed up the activation system to use AJAX, but now that we've done that, it's just clumsy, janky, and a little confusing from a usability standpoint. We can display the form in a modal dialog instead:

Setting recipe inputs in a modal dialog

CommentFileSizeAuthor
#7 3539184-7.png154.1 KBphenaproxima
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Status: Active » Postponed

I tried hard to do this, but it turned out to be damn near impossible because trying to make this work puts you right in the middle of a fistfight between the Form API, Batch API, and AJAX API. A fight which nobody's winning, but you are definitely losing.

I discussed this with @tim.plunkett, maintainer of the Form API, and he felt that this is too much of a Pandora's box to justify the slightly improved usability. What we have now works just fine, in the sense that nobody has complained about it, even though it's not necessarily the ideal UX.

So I'll postpone this indefinitely and leave it for a braver (and/or foolhardier) and more skilled keyboard warrior than myself.

phenaproxima’s picture

Assigned: Unassigned » chrisfromredfin
Status: Postponed » Needs work
Issue tags: +stable blocker

Well sheeeeit. @pameeela did her sorcery thing when I told her this couldn't be done, and wouldn'tchaknow, I found a way: OpenModalDialogWithUrl, a core AJAX command that does what we want (by inadvertently making the form action not point to an existing AJAX route, which is why this was breaking before).

This is now fully on.

phenaproxima’s picture

Status: Needs work » Needs review

phenaproxima’s picture

Issue summary: View changes
StatusFileSize
new154.1 KB

Here's a screenshot of what the form now looks like.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

Status: Needs review » Fixed

That's a really nice improvement.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.