Problem/Motivation

When #1493324: Inline form errors for accessibility and UX is commited we must fix the classnames so it fits with the coding standards.

Proposed resolution

form-error-message to field-item--error-message and form-error to form-item--error etc

Remaining tasks

get #1493324: Inline form errors for accessibility and UX into core ;)

User interface changes

none

API changes

css classes

CommentFileSizeAuthor
#5 after-3.png112 KBmanjit.singh
#5 after-2.png117.98 KBmanjit.singh
#5 after-1.png81.9 KBmanjit.singh
#5 after.png110.23 KBmanjit.singh
#1 inline_form_errors_classnames_namestandard-2501903-1.patch5.21 KBpguillard

Comments

pguillard’s picture

pguillard commented
StatusFileSize
new inline_form_errors_classnames_namestandard-2501903-1.patch5.21 KB

it's a start ..

pguillard’s picture

pguillard commented
Status: Active » Needs review
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Assigned: Unassigned » manjit.singh
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Issue summary: View changes
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Assigned: manjit.singh » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after.png110.23 KB
new after-1.png81.9 KB
new after-2.png117.98 KB
new after-3.png112 KB

I have tested the error and their respective classes. Please check the screenshots of error messages.

alt

alt

alt

alt

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the manual testing!

I checked to confirm that this replaces all instances of these classes:

[mandelbrot:maintainer | Sat 14:18:05] $ grep -r "form\-error\-message" *
[mandelbrot:maintainer | Sat 14:18:11] $ grep -r "form\-error" *
[mandelbrot:maintainer | Sat 14:18:16] $

This issue only changes user-facing strings, CSS, or markup, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. Thanks!

  • xjm committed 134aba9 on 8.0.x 
    Issue #2501903 by pguillard, Manjit.Singh: inline form errors classnames...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.