Problem/Motivation

If there's a validation error in view's edit form, the following error is logged:
User error: "preview" is an invalid render array key in Drupal\Core\Render\Element::children() (line 101 of core/lib/Drupal/Core/Render/Element.php).

Steps to reproduce:
1. Edit front page view
2. Change the "Show" setting from content to fields
3. Click preview

Expected: You should see a message 'Unable to preview due to validation errors.'.

Actual: No message.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 views-preview-error-2505997-4.patch2.5 KBpeterpoe
after.png35.02 KBolli
before.png31.4 KBolli
views-preview-error.patch593 bytesolli

Comments

phantomvish’s picture

phantomvish commented

Makes sense, Patch works as expected. +1 rtbc

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Fix looks good, but needs a test.

dpopdan queued views-preview-error.patch for re-testing.

peterpoe’s picture

peterpoe commented
Priority: Minor » Normal
Status: Needs work » Needs review
Issue tags: -Needs tests

Test here

peterpoe’s picture

peterpoe commented
StatusFileSize
new views-preview-error-2505997-4.patch2.5 KB

Sorry, here

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Manually tested this and fix is good.

Patch looks good to me now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Nice bug fix and test - thanks. Committed ff5ac65 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 58bd5a3 on 8.1.x 
    Issue #2505997 by olli, peterpoe, Lendude: User error: "preview" is an...

  • alexpott committed ff5ac65 on 
    Issue #2505997 by olli, peterpoe, Lendude: User error: "preview" is an...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.