Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
#2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!) uncovered a cache tag we forgot for Tracker module's responses:
- the tracker shows the comment counts for all listed nodes, which means we also need the Comment entity's list cache tag
- history (new/updated markers) is only supported for authenticated users, so Tracker only adds the JS library for that for authenticated users. This is good. But it was not yet setting the corresponding cache context.
Proposed resolution
Fix it.
Remaining tasks
Review.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | interdiff.txt | 1.05 KB | effulgentsia |
| #15 | tracker_cacheability_fixes-2554585-15.patch | 2.12 KB | effulgentsia |
| #13 | tracker_cacheability_fixes-2554585-13.patch | 2.1 KB | wim leers |
Comments
Comment #2
wim leersComment #3
wim leersComment #4
moshe weitzman commentedTrivial fixes. Thanks for the test coverage. One bot came back green so setting to RTBC early.
Comment #8
wim leersRandom testbot fail it seems. DrupalCI *does* mark it as green.
Comment #9
wim leersRe-RTBC'ing per #4 — only was un-RTBC'd because of a testbot fluke.
Comment #11
wim leersRebased, one small conflict had to be solved.
Comment #12
wim leersLet's wait for #2530846: Fix and improve comment cache tag usage to land first, I think that may remove the need for the cache tag changes here.
Comment #13
wim leers#2530846: Fix and improve comment cache tag usage improved HEAD: it ensures that comment created/edited/deleted on entities also invalidates the cache tags of those entities. Which means this patch no longer needs to add the
comment_listcache tag :)(No interdiff because there was a rebase conflict too and it's only a tiny patch anyway. Basically, the patch is identical to the previous patch, with just the cache tag changes removed.)
Comment #14
moshe weitzman commentedTrivial fix. Please wait for green before merge,
Comment #15
effulgentsia commentedI think this is clearer. What do you think?
Comment #16
wim leersClearer indeed! :)
Comment #17
effulgentsia commentedAdding credit to Moshe for reviewing.
Comment #18
effulgentsia commentedPushed to 8.0.x. Thanks!