Problem/Motivation

In class ConditionManager [file: core/lib/Drupal/Core/Condition/ConditionManager.php],
Overriding Drupal\Component\Plugin\PluginManagerBase::createInstance().

and the PHPdoc for the function is missing.

CommentFileSizeAuthor
#8 2614604-8.patch644 bytesrakesh.gectcr
#5 2614604-5.patch645 bytesrakesh.gectcr
#2 2614604-1.patch878 bytesrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new 2614604-1.patch878 bytes
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Just use {@inheritdoc} instead ...

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new 2614604-5.patch645 bytes

Status: Needs review » Needs work

The last submitted patch, 5: 2614604-5.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

... instead of the existing documentation.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new 2614604-8.patch644 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Thanks! Sorry for delay; I've been on vacation.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks again! Committed to both 8.x branches.

  • jhodgdon committed b33ed03 on 8.0.x 
    Issue #2614604 by rakesh.gectcr, dawehner: PHPdoc is missing for an...

  • jhodgdon committed e5db043 on 
    Issue #2614604 by rakesh.gectcr, dawehner: PHPdoc is missing for an...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.