The Messages handler Drupal\views\Plugin\views\area\Messages gives a broken/missing handler when added to a View.

Steps to reproduce:
- Take any View
- Click Header -> Add
- Add Messages
- Click Add and configure header

CommentFileSizeAuthor
#10 messages_handler_missing-2624890-10.patch3.2 KBlendude
#10 interdiff-2624890-8-10.txt481 byteslendude
#8 messages_handler_missing-2624890-8.patch3.2 KBlendude
#8 interdiff-2624890-4-8.txt528 byteslendude
#4 messages_handler_missing-2624890-4.patch3.22 KBlendude
#4 messages_handler_missing-2624890-4-TEST_ONLY.patch2.8 KBlendude
#2 messages_handler_missing-2624890-2.patch433 byteslendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new messages_handler_missing-2624890-2.patch433 bytes

Set to needs review to run testbot but this still needs tests.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Yeah we really need tests but good catch!

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new messages_handler_missing-2624890-4-TEST_ONLY.patch2.8 KB
new messages_handler_missing-2624890-4.patch3.22 KB

Test. Interdiff is the test only patch.

The last submitted patch, 4: messages_handler_missing-2624890-4-TEST_ONLY.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/views/src/Tests/Handler/AreaMessagesTest.php
@@ -0,0 +1,45 @@
+    $view->destroy();

Note: This is not really needed, anyway, feel free to fix it.

The last submitted patch, 4: messages_handler_missing-2624890-4-TEST_ONLY.patch, failed testing.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new interdiff-2624890-4-8.txt528 bytes
new messages_handler_missing-2624890-8.patch3.2 KB

small clean up per #6

dawehner’s picture

dawehner
Primary language German
commented

Thank you!

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new interdiff-2624890-8-10.txt481 bytes
new messages_handler_missing-2624890-10.patch3.2 KB

Minor comment copy/paste leftover fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

@Lendude you are on a roll of great views bugfixes and improving test coverage.

Committed 8c0db2a and pushed to 8.0.x. Thanks!

  • alexpott committed fa9d712 on 8.1.x 
    Issue #2624890 by Lendude: Views Messages area handler gives broken/...

  • alexpott committed 8c0db2a on 
    Issue #2624890 by Lendude: Views Messages area handler gives broken/...
dawehner’s picture

dawehner
Primary language German
commented

Yeah seriously, lendude, thank you so much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.