Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.MigrationBuilder should have an interface, contrib code should not type hint against the implementation because as per DIP. This in turn prevents the service from being replace in the container.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2626476-2.patch | 1.82 KB | benjy |
Comments
Comment #2
benjy commentedPatch attached.
Comment #3
phenaproximaRTBC assuming Drupal CI passes it.
Comment #4
cilefen commentedThis is needed, but it is an API improvement so it goes to 8.1.x.
Comment #5
phenaproximaMigrate is experimental, so it's not subject to the normal rules. A committer should confirm this.
Comment #6
alexpottThis seems fine to go into 8.0.x - it does not break exiting contrib migrations and other migrate projects are helped by having an interface.
Comment #7
benjy commentedBack to 8.0.x
Comment #8
alexpott#6 was my framework manager review - this is an experimental module and this change does not majorly disrupt contrib implementations on the main API. This change would not be okay for stable core code.
Comment #9
alexpottCommitted a853693 and pushed to 8.0.x and 8.1.x. Thanks!