There is a typo in plugin class description.

https://api.drupal.org/api/drupal/core%21modules%21node%21src%21Plugin%2...

CommentFileSizeAuthor
#7 core-fix_typo_in_node_plugin_class_description-2629712-7-D8.patch555 bytesleolandotan
#3 core-fix_typo_in_node_plugin_class_description-2629712-0-D8.patch585 bytesleolandotan

Comments

Chi created an issue. See original summary.

leolandotan’s picture

leolandotan commented
Assigned: Unassigned » leolandotan
leolandotan’s picture

leolandotan commented
Status: Active » Needs review
StatusFileSize
new core-fix_typo_in_node_plugin_class_description-2629712-0-D8.patch585 bytes

Hi,

I have create a simple patch for this and just double checked and applied it to the 8.0.x branch by:

  1. git checkout 8.0.x
  2. git apply -v core-fix_typo_in_node_plugin_class_description-2629712-0-D8.patch
chi’s picture

chi commented
Title: Typo in node argument default plugin. » Typo in node argument default plugin
Assigned: leolandotan » Unassigned
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Can't we just remove the sentence - I don't think it really helps anyone?

shreya shetty’s picture

shreya shetty commented
Assigned: Unassigned » shreya shetty
leolandotan’s picture

leolandotan commented
Status: Needs work » Needs review
StatusFileSize
new core-fix_typo_in_node_plugin_class_description-2629712-7-D8.patch555 bytes

Here I have added the minor changes that @alexpott proposed.

I have also made sure to pull an updated code base of 8.0.x before applying the new change.

chi’s picture

chi commented
Assigned: shreya shetty » Unassigned
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f0cbbd6 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 503100b on 8.1.x 
    Issue #2629712 by leolando.tan: Typo in node argument default plugin

  • alexpott committed f0cbbd6 on 
    Issue #2629712 by leolando.tan: Typo in node argument default plugin

(...
shreya shetty’s picture

shreya shetty commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.