Contextual Links do not respect pathPrefix

Could we use the Drupal.url method directly for it?

#3++

Drupal.url(drupalSettings.path.currentPath)

Adding related.

I'm experiencing the same issues in my current project. Here is a patch that uses Drupal.url which seems to work fine.

It would be nice to add some javascript test coverage to prove that things are working.

Drupal.url does not encode the path, would it be better to do this?

--- a/core/modules/contextual/js/contextual.js
+++ b/core/modules/contextual/js/contextual.js
@@ -55,7 +55,7 @@
       .prepend(Drupal.theme('contextualTrigger'));

     // Set the destination parameter on each of the contextual links.
-    var destination = 'destination=' + Drupal.encodePath(drupalSettings.path.currentPath);
+    var destination = 'destination=' + Drupal.encodePath(Drupal.url(drupalSettings.path.currentPath));

#10 is right.

I also think #10 is the best way to solve this - it solved my editors' problems.
Patch attached and setting to need-review.

Aslo added tests and set to drupal 8.3.x-dev (that's what I'm running) - issue was 8.0.x-dev

Reroll for 8.4

Patch #12 works for me with Drupal 8.3.x

Triggering Bots.

Looks okay, but this is causing tests to fail and it's modifying only core/misc/drupal.js, it should also modify core/misc/drupal.es6.js.

Here are some new patches that also target the ES6 script files. I provide two different patch versions for 8.5.x and 8.6.x, because in 8.6.x the ES6 file is slightly different to 8.5.x.

I guess there are some tests that need to be updated for this change ;)

I hit this today with path prefixes. #25.1 fixes this problem for me and still applies to 8.7.x. Digging into the two failing test cases, I think both of them demonstrate this bug:

$this->assertTrue(strstr($href, '/admin/structure/block/manage/custom/settings-tray?destination=user/2') !== FALSE);

$this->assertContains("/admin/structure/block/manage/$block_id/settings-tray?destination=user/2", $link->getAttribute('href'));

Both fails are because after this patch, the new destination param is subdirectory/user/2 which I believe is correct, given Drupal CI runs under a subdirectory.

Uploading a new test case so we have explicit coverage and fixing the existing tests.

This looks good. Manually tested and it does what it says on the box. New test is great.

adding review credits

Committed 12c3109 and pushed to 8.7.x. Thanks!

c/p as 83e35e57aa and pushed to 8.6.x